>-----Original Message-----
>From: Jacopo Mondi <jacopo.mo...@ideasonboard.com>
>Sent: Saturday, August 2, 2025 5:23 PM
>To: Mauro Carvalho Chehab <mche...@kernel.org>; Devarsh Thakkar
><devar...@ti.com>; Benoit Parrot <bpar...@ti.com>; Hans Verkuil
><hverk...@kernel.org>; Mike Isely <is...@pobox.com>; Laurent Pinchart
><laurent.pinch...@ideasonboard.com>; Hans de Goede <ha...@kernel.org>;
>Parthiban Veerasooran <parthiban.veerasoo...@microchip.com>; Christian
>Gromm <christian.gr...@microchip.com>; Greg Kroah-Hartman
><gre...@linuxfoundation.org>; Alex Shi <al...@kernel.org>; Yanteng Si
><si.yant...@linux.dev>; Dongliang Mu <dz...@hust.edu.cn>; Jonathan
>Corbet <cor...@lwn.net>; Tomasz Figa <tf...@chromium.org>; Marek
>Szyprowski <m.szyprow...@samsung.com>; Andy Walls
><awa...@md.metrocast.net>; Michael Tretter <m.tret...@pengutronix.de>;
>Pengutronix Kernel Team <ker...@pengutronix.de>; Bin Liu
><bin....@mediatek.com>; Matthias Brugger <matthias....@gmail.com>;
>AngeloGioacchino Del Regno <angelogioacchino.delre...@collabora.com>;
>Dmitry Osipenko <dig...@gmail.com>; Thierry Reding
><thierry.red...@gmail.com>; Jonathan Hunter <jonath...@nvidia.com>;
>Mirela Rabulea <mirela.rabu...@nxp.com>; Shawn Guo
><shawn...@kernel.org>; Sascha Hauer <s.ha...@pengutronix.de>; Fabio
>Estevam <feste...@gmail.com>; Kieran Bingham
><kieran.bingham+rene...@ideasonboard.com>; Michal Simek
><michal.si...@amd.com>; Ming Qian <ming.q...@nxp.com>; Eagle Zhou
><eagle.z...@nxp.com>; Xavier Roumegue (OSS)
><xavier.roume...@oss.nxp.com>; Philipp Zabel <p.za...@pengutronix.de>;
>Vikash Garodia <quic_vgaro...@quicinc.com>; Dikshita Agarwal
><quic_diksh...@quicinc.com>; Abhinav Kumar <abhinav.ku...@linux.dev>;
>Bryan O'Donoghue <bryan.odonog...@linaro.org>; Sylwester Nawrocki
><sylvester.nawro...@gmail.com>; Jernej Skrabec <jernej.skra...@gmail.com>;
>Chen-Yu Tsai <w...@csie.org>; Samuel Holland <sam...@sholland.org>;
>Daniel Almeida <daniel.alme...@collabora.com>; Neil Armstrong
><neil.armstr...@linaro.org>; Kevin Hilman <khil...@baylibre.com>; Jerome
>Brunet <jbru...@baylibre.com>; Martin Blumenstingl
><martin.blumensti...@googlemail.com>; Nas Chung
><nas.ch...@chipsnmedia.com>; Jackson Lee
><jackson....@chipsnmedia.com>; Minghsiu Tsai
><minghsiu.t...@mediatek.com>; Houlong Wei <houlong....@mediatek.com>;
>Andrew-CT Chen <andrew-ct.c...@mediatek.com>; Tiffany Lin
><tiffany....@mediatek.com>; Yunfei Dong <yunfei.d...@mediatek.com>;
>Geert Uytterhoeven <geert+rene...@glider.be>; Magnus Damm
><magnus.d...@gmail.com>; Mikhail Ulyanov
><mikhail.ulya...@cogentembedded.com>; Jacob Chen <jacob-
>c...@iotwrt.com>; Ezequiel Garcia <ezequ...@vanguardiasur.com.ar>; Heiko
>Stuebner <he...@sntech.de>; Detlev Casanova
><detlev.casan...@collabora.com>; Krzysztof Kozlowski <k...@kernel.org>;
>Alim Akhtar <alim.akh...@samsung.com>; Sylwester Nawrocki
><s.nawro...@samsung.com>; Łukasz Stelmach <l.stelm...@samsung.com>;
>Andrzej Pietrasiewicz <andrzejtp2...@gmail.com>; Jacek Anaszewski
><jacek.anaszew...@gmail.com>; Andrzej Hajda <andrzej.ha...@intel.com>;
>Fabien Dessenne <fabien.desse...@foss.st.com>; Hugues Fruchet
><hugues.fruc...@foss.st.com>; Jean-Christophe Trotin <jean-
>christophe.tro...@foss.st.com>; Maxime Coquelin
><mcoquelin.st...@gmail.com>; Alexandre Torgue
><alexandre.tor...@foss.st.com>; Nicolas Dufresne
><nicolas.dufre...@collabora.com>; Benjamin Gaignard
><benjamin.gaign...@collabora.com>; Steve Longerbeam
><slongerb...@gmail.com>; Maxime Ripard <mrip...@kernel.org>; Paul
>Kocialkowski <pa...@sys-base.io>; Niklas Söderlund
><niklas.soderl...@ragnatech.se>; Robert Foss <rf...@kernel.org>; Todor
>Tomov <todor....@gmail.com>; Vladimir Zapolskiy
><vladimir.zapols...@linaro.org>; Corentin Labbe <cla...@baylibre.com>;
>Sakari Ailus <sakari.ai...@linux.intel.com>; Bingbu Cao
><bingbu....@intel.com>; Tianshu Qiu <tian.shu....@intel.com>; Stanislaw
>Gruszka <stanislaw.grus...@linux.intel.com>
>Cc: linux-me...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-
>stag...@lists.linux.dev; linux-...@vger.kernel.org; linux-arm-
>ker...@lists.infradead.org; linux-media...@lists.infradead.org; linux-
>te...@vger.kernel.org; i...@lists.linux.dev; linux-renesas-...@vger.kernel.org;
>linux-arm-...@vger.kernel.org; linux-samsung-...@vger.kernel.org; linux-
>su...@lists.linux.dev; linux-...@vger.kernel.org; linux-
>amlo...@lists.infradead.org; linux-rockc...@lists.infradead.org; linux-
>st...@st-md-mailman.stormreply.com; mjpeg-users@lists.sourceforge.net;
>Jacopo Mondi <jacopo.mo...@ideasonboard.com>
>Subject: [EXT] [PATCH 13/65] media: amphion: Make some vpu_v4l2 functions
>static
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>From: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
>
>Some functions defined in vpu_v4l2.c are never used outside of that
>compilation unit. Make them static.
>
>Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
>Signed-off-by: Jacopo Mondi <jacopo.mo...@ideasonboard.com>
Reviewed-by: Ming Qian <ming.q...@oss.nxp.com>
>---
> drivers/media/platform/amphion/vpu_v4l2.c | 12 +++++++++---
>drivers/media/platform/amphion/vpu_v4l2.h | 8 --------
> 2 files changed, 9 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.c
>b/drivers/media/platform/amphion/vpu_v4l2.c
>index
>74668fa362e24fd34829b500e99c8455a9413fc1..306d94e0f8e79faaacfa35b28e
>5786860f7bd1ca 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.c
>+++ b/drivers/media/platform/amphion/vpu_v4l2.c
>@@ -24,6 +24,11 @@
> #include "vpu_msgs.h"
> #include "vpu_helpers.h"
>
>+static char *vpu_type_name(u32 type)
>+{
>+ return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture"; }
>+
> void vpu_inst_lock(struct vpu_inst *inst) {
> mutex_lock(&inst->lock);
>@@ -42,7 +47,7 @@ dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer
>*vb, u32 plane_no)
> vb->planes[plane_no].data_offset; }
>
>-unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no)
>+static unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32
>+plane_no)
> {
> if (plane_no >= vb->num_planes)
> return 0;
>@@ -81,7 +86,7 @@ void vpu_v4l2_set_error(struct vpu_inst *inst)
> vpu_inst_unlock(inst);
> }
>
>-int vpu_notify_eos(struct vpu_inst *inst)
>+static int vpu_notify_eos(struct vpu_inst *inst)
> {
> static const struct v4l2_event ev = {
> .id = 0,
>@@ -573,7 +578,8 @@ static void vpu_vb2_buf_finish(struct vb2_buffer *vb)
> call_void_vop(inst, on_queue_empty, q->type); }
>
>-void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state)
>+static void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type,
>+ enum vb2_buffer_state state)
> {
> struct vb2_v4l2_buffer *buf;
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.h
>b/drivers/media/platform/amphion/vpu_v4l2.h
>index
>56f2939fa84d07b7ea07e889ab5ad3bb7ca9ab5c..4a87b06ae520306ede356b6f
>3309d8b4a67c204a 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.h
>+++ b/drivers/media/platform/amphion/vpu_v4l2.h
>@@ -26,15 +26,12 @@ void vpu_skip_frame(struct vpu_inst *inst, int count);
>struct vb2_v4l2_buffer *vpu_find_buf_by_sequence(struct vpu_inst *inst, u32
>type, u32 sequence); struct vb2_v4l2_buffer *vpu_find_buf_by_idx(struct
>vpu_inst *inst, u32 type, u32 idx); void vpu_v4l2_set_error(struct vpu_inst
>*inst); -int vpu_notify_eos(struct vpu_inst *inst); int
>vpu_notify_source_change(struct vpu_inst *inst); int
>vpu_set_last_buffer_dequeued(struct vpu_inst *inst, bool eos); -void
>vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state); int vpu_get_num_buffers(struct vpu_inst *inst, u32
>type); bool vpu_is_source_empty(struct vpu_inst *inst);
>
> dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer *vb, u32 plane_no); -
>unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no); static
>inline struct vpu_format *vpu_get_format(struct vpu_inst *inst, u32 type) {
> if (V4L2_TYPE_IS_OUTPUT(type))
>@@ -43,11 +40,6 @@ static inline struct vpu_format *vpu_get_format(struct
>vpu_inst *inst, u32 type)
> return &inst->cap_format; }
>
>-static inline char *vpu_type_name(u32 type) -{
>- return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture";
>-}
>-
> static inline int vpu_vb_is_codecconfig(struct vb2_v4l2_buffer *vbuf) {
> #ifdef
>V4L2_BUF_FLAG_CODECCONFIG
>
>--
>2.49.0
_______________________________________________
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
