Element.java contains the following implementation of copyTags(Element
other):
/**
* Copy the tags of the other element. Only to be used internally
* by subclasses.
* @param other The other element. All its tags will be copied to this
* element.
*/
public void copyTags(Element other) {
if (other.tags != null)
tags = other.tags.copy();
}
So the copyTags does not add but replace all tags. But only if the other
element has tags. This is weird. So I think replaceTags would be a
better name and the other.tags==null case should be handled:
public void replaceTags(Element other) {
if (other.tags == null)
tags = null;
else
tags = other.tags.copy();
}
Is this ok or are there any side effects I am not aware of?
WanMil
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
