On Tue, Aug 10, 2010 at 11:33:43AM +0200, Valentijn Sessink wrote:
I seem to remember that someone (Felix?) mentioned that Garmin
bicycle routing knows two values of road_speed: zero and nonzero.
Before r1431, highway=path and highway=cycleway got different
road_speed: 0 and 1, respectively. Starting with r1431, both have
road_speed=1. Could that be the source of the breakage?
I thought it was having unclassified roads get road_class 0. But to be
honest: I never tested. I just rely on r1430 for my bicycle maps. Then
again, when I cycled from Copenhagen to Amsterdam this summer, I used
the regular maps and they worked pretty well - in Denmark and Germany,
that is. So most likely it has something to do with the density of
bicycle roads, combined with the road class changes.
So please ignore my comments for now - if I have time, I'll try to test
a more fine grained r1430-1431 change and report my findings.
I am planning to remove the { add bicycle=no; add foot=no } from
highway=trunk and to restore non-bicycle paths to road_speed=0.
Do you have test cases in mind? Can you try the attached patch?
Long term, I would remove the "Convert generic path to most specific"
and translate the highway=(cycleway|footway|bridleway) to highway=path
instead. In that way, we can better keep the access tags intact.
Best regards,
Marko
Index: ../mkgmap/resources/styles/default/lines
===================================================================
--- ../mkgmap/resources/styles/default/lines (revision 1667)
+++ ../mkgmap/resources/styles/default/lines (working copy)
@@ -49,9 +49,9 @@ highway=*
{ add mkgmap:unpaved=1 }
# Convert generic path to most specific
-highway=path & bicycle=designated {set highway=cycleway }
-highway=path & horse=designated {set highway=bridleway }
-highway=path & foot=designated {set highway=footway }
+highway=path & (bicycle=designated|bicycle=official) {set highway=cycleway }
+highway=path & (horse=designated|horse=official) {set highway=bridleway }
+highway=path & (foot=designated|foot=official) {set highway=footway }
# Roundabouts
junction=roundabout & highway=trunk [0x0c road_class=3 road_speed=2 resolution 18]
@@ -71,9 +71,10 @@ highway=* & disused=yes [0x07 road_class
# Ways sorted roughly by descending order of class
highway=motorway {add oneway = yes; add bicycle = no; add foot = no } [0x01 road_class=4 road_speed=7 resolution 14]
highway=motorway_link {add oneway = yes; add bicycle = no; add foot = no } [0x09 road_class=3 road_speed=2 resolution 16]
-highway=trunk {add bicycle = no; add foot = no} [0x02 road_class=4 road_speed=5 resolution 16]
-highway=trunk_link {add bicycle = no; add foot = no} [0x09 road_class=3 road_speed=2 resolution 18]
-highway=* & motorroad=yes {add bicycle = no; add foot = no} [0x02 road_class=4 road_speed=4 resolution 16]
+highway=* & motorroad=yes {add bicycle = no; add foot = no}
+highway=trunk [0x02 road_class=4 road_speed=5 resolution 16]
+highway=trunk_link [0x09 road_class=3 road_speed=2 resolution 18]
+highway=* & motorroad=yes [0x02 road_class=4 road_speed=4 resolution 16]
highway=primary [0x03 road_class=3 road_speed=4 resolution 19]
highway=primary_link [0x08 road_class=3 road_speed=1 resolution 19]
highway=secondary [0x04 road_class=2 road_speed=3 resolution 20]
@@ -91,7 +92,7 @@ highway=byway [0x16 road_class=0 road_sp
highway=service [0x07 road_class=0 road_speed=2 resolution 22]
highway=cycleway {add access = no; add bicycle = yes; add foot = yes} [0x16 road_class=0 road_speed=1 resolution 23]
highway=footway {add access = no; add foot = yes} [0x16 road_class=0 road_speed=0 resolution 23]
-highway=path {add access = no; add bicycle = yes; add foot = yes} [0x16 road_class=0 road_speed=1 resolution 23]
+highway=path {add access = no; add bicycle = yes; add foot = yes} [0x16 road_class=0 road_speed=0 resolution 23]
highway=steps {add access = no; add foot = yes} [0x16 road_class=0 road_speed=0 resolution 23]
highway=track [0x0a road_class=0 road_speed=1 resolution 21]
highway=unsurfaced [0x0a road_class=0 road_speed=1 resolution 21]
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
