Hi,
Markus is right. The mp code must check if the mp itself contains the
relevant polygon tags or if the tagging should be taken from the outer
ways. For this purpose a list of known polygon tags is used and up to
now leisure is not in this list.
Attached patch extends this list by the tags "leisure", "military",
"man_made", "place", "tourism", "amenity". I have found them by
analyzing the europe OSM dump so this should catch most cases.
By the way: the direction of ways is not evaluated.
WanMil
Hi Charlie,
With the tests I have just done I have found the leisure tag no longer works
with multipolygons.
Regards,
Markus_g
-----Original Message-----
From: Charlie Ferrero [mailto:[email protected]]
Sent: Friday, 24 September 2010 4:31 PM
To: Markus
Cc: 'Development list for mkgmap'
Subject: Re: [mkgmap-dev] Trouble getting some multipolygons to render
inmkgmap
On 24/09/2010 10:42, Markus wrote:
The other relations seem to have water reversed also.
For the last relation I would try reversing the swimming pool way and the
outer way to match the coastline way. Although I wouldn't have thought
that
this would matter.
Markus_g
For the
Markus,
Thanks for looking into this. Are you sure the sense of the way around
water matters? I know that it is important for coastlines, but couldn't
find any suggestion that it matters for other inland water masses, e.g.
natural=water (http://wiki.openstreetmap.org/wiki/Tag:natural%3Dwater)
doesn't mention it.
Also, the multipolygon "usage" section on the wiki
(http://wiki.openstreetmap.org/wiki/Relation:multipolygon) states:
"The direction of the ways does not matter"
--
Charlie
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Index: src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java
===================================================================
--- src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java (revision 1702)
+++ src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java (working copy)
@@ -70,9 +70,9 @@
* if one of these tags are contained in the multipolygon then the outer
* ways use the mp tags instead of their own tags.
*/
- private static final List<String> polygonTags = Arrays.asList("boundary",
- "natural", "landuse", "land_area", "building", "waterway");
-
+ private static final Collection<String> polygonTags = new HashSet<String>(Arrays.asList("boundary",
+ "natural", "landuse", "land_area", "building", "waterway",
+ "leisure", "military", "man_made", "place", "tourism", "amenity"));
/**
* Create an instance based on an existing relation. We need to do this
* because the type of the relation is not known until after all its tags
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
