Hi Steve,

On Fri, May 27, 2011 at 11:29:15AM +0100, Steve Ratcliffe wrote:
There could still be bugs in the mkgmap pbf reader code. Although it has been in for a while, its probably not been used much until now.

The attached patch zaps the mkgmap warnings about unreferenced nodes.

With your patch applied on top of the splitter-pbf branch, I got exactly the same warnings through my filter that I got through the XML toolchain today. The gmapsupp.img size is identical, and the warnings about unclosed polygons are gone.

Can you please commit your patch to the splitter-pbf branch? Is it OK to commit the warning-zapping patch to mkgmap, or would it be feasible to do something similar to Osmosis --used-node in splitter?

        Marko
Index: src/uk/me/parabola/mkgmap/reader/osm/bin/OsmBinHandler.java
===================================================================
--- src/uk/me/parabola/mkgmap/reader/osm/bin/OsmBinHandler.java	(revision 1955)
+++ src/uk/me/parabola/mkgmap/reader/osm/bin/OsmBinHandler.java	(working copy)
@@ -152,7 +152,7 @@ public class OsmBinHandler extends OsmHa
 						// nodes (way joins) will have highwayCount > 1
 						co.incHighwayCount();
 					} else {
-						log.warn("Way", way.toBrowseURL(), "references undefined node", nid);
+						log.info("Way", way.toBrowseURL(), "references undefined node", nid);
 					}
 				}
 
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to