Attached patch removes the described obsolete naming of streets by using POIs.

WanMil

Hi,

while crawling through the mkgmap sources I found another mystic tagging
which I think come from the time before the style system was so powerful.

Look at commit r1267:
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&path=%2F&rev=1267&peg=1267

If the first point of a road (example highway=secondary) has a node that
is tagged with secondary_name this value is taken as name for the road.

Is this still used?
Otherwise I want to remove that.

WanMil
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Index: src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java
===================================================================
--- src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(revision 2423)
+++ src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(working copy)
@@ -799,22 +799,9 @@
 		if("true".equals(way.getTag("mkgmap:way-has-pois"))) {
 			List<Coord> points = way.getPoints();
 
-			// for highways, see if its name is set by a POI located
-			// at the first point
-			if(points.size() > 1 && points.get(0) instanceof CoordPOI) {
-				String highwayKind = way.getTag("highway");
-				if(highwayKind != null) {
-					Node poiNode = ((CoordPOI)points.get(0)).getNode();
-					String nameFromPoi = poiNode.getTag(highwayKind + "_name");
-					if(nameFromPoi != null) {
-						way.setName(nameFromPoi);
-						log.info(highwayKind + " " + way.getId() + " named '" + way.getName() + "'");
-					}
-				}
-			}
-
-			// now look for POIs that modify the way's road class or
-			// speed
+			// look for POIs that modify the way's road class or speed
+			// this could be e.g. highway=traffic_signals that reduces the
+			// road speed to cause a short increase of traveling time
 			for(int i = 0; i < points.size(); ++i) {
 				Coord p = points.get(i);
 				if(p instanceof CoordPOI) {
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to