Hi Gerd,

I've gone through all calls of isClosed(). I am quite sure all in all calls it should be checked for identity.

But there are some other changes that need to be done (not complete!!):
SeaGenerator
  beginMap (line 770) need to be IdentityHashMap

BoundaryRelation
  line 387 should be an IdentityHashMap?
  line 474+477: Coord.equals(..) maybe check for identity?

MultipolgyonRelation
  line 468 should be an IdentityHashMap?
  line 553+556: Coord.equals(..) maybe check for identity?

I guess there are a lot of other places where Coord.equals is used instead of identity.

WanMil



Hi WanMil,

 > Before fixing that all calls to this method need to be checked if they
 > rely on the current behaviour.

I agree. The problem is that the method is used in rather complex
algos, so it's difficult for me to answer this question, esp.
when we also have to consider the changes in the high prec branch.

Gerd


_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to