Hi Gerd
I'll check on the rounding, fix the warn>debug and add the pre-test to
the splitting into areas.
I've just loaded GPSMapEdit and see what you mean about the long lines
of buildings - they are wavy!. I'll work out why it is happening.
Regards
Ticker
On Fri, 2016-11-11 at 01:25 -0700, Gerd Petermann wrote:
> Hi Ticker,
>
> sorry, still some problems:
> 1) I think I found an error in method Area.roundPof2(int val, int
> shift)
> I wanted to find out why you did not use Util.roundUp(int val, int
> shift).
>
> For val=-9567 and shift=4 I see
> -9568 from your routine and
> -9552 from the other
> So it seems your routine doesn't round up as the javadoc says.
> So either the doc or the result is wrong.
>
> 2) Please check the new log messages. The severity level warning
> should not
> be used for debug messages.
> A warning message should be understandable for the end user.
>
> 3) Reg. performance:
> I think most of the area.intersect calls are not needed when you add
> this
> block at the beginning of
> splitIntoAreas():
> // quick check if bbox of shape lies fully inside one
> of the areas
> for (int areaIndex = 0; areaIndex < areas.length;
> ++areaIndex) {
> if
> (areas[areaIndex].getBounds().contains(e.getBounds())) {
> used[areaIndex] = true;
> areas[areaIndex].addShape(e);
> return;
> }
> }
> // Shape crosses area(s), we have to split it
> // Convert to a awt area
> ...
>
> ciao,
> Gerd
>
>
>
>
>
> --
> View this message in context: http://gis.19327.n8.nabble.com/patch-to
> -write-polygons-in-decreasing-order-tp5884038p5885742.html
> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> _______________________________________________
> mkgmap-dev mailing list
> [email protected]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
