Gents,
skipping empty lines might be a problem.... or at least was one.

According documentation and my own experience the first line of the file handed over via --copyright-file is not shown on the garmin devices, but on BaseCamp.

In order to have all licenses properly shown on the device with no 'garbage' in BaseCamp, empty lines should not be skipped.

In my environment I use the same file for the options --copyright-file and --license file... with the effect, that BaseCamp shows it twice whereas GarminDevice shows it once.

Regarding UTF8 in style files:
My style files are in UTF-8 Encoding with BOM. This independant if I build a cp1252, cp1251 or unicode map.

Cheers
Patrik

On 29.12.2016 14:40, Gerd Petermann wrote:
Hi Mike,

if I got that right the original code ignores empty lines in the licence file, 
the patch doesn't.
Is that intended?
I have no idea what's better, so I'll wait for a comment from Steve.

Gerd
________________________________________
Von: mkgmap-dev <[email protected]> im Auftrag von Mike Baggaley 
<[email protected]>
Gesendet: Donnerstag, 29. Dezember 2016 12:53:15
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Gerd, please find an updated patch for improvements to the copyright
reader. As discussed, this updates the documentation to say that the files
must be UTF-8 encoded, and improves the error message to give the cause of
the failure if the copyright or license file cannot be read.

The code for reading style files does not appear to specify UTF-8.

Please try and commit if happy.

Thanks,
Mike
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to