Hi Andrzej, okay, I can add the 2nd test as well. I wonder if we should disallow to modify the special tags. That would allow to remove rules which would can never be true instead of adding and evaluating the tags for each element. On the other hand, the current patch is very simple, the improved version would require more code. Just an idea..
Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Andrzej Popowski <[email protected]> Gesendet: Montag, 13. Februar 2017 18:32:46 An: [email protected] Betreff: Re: [mkgmap-dev] To do: If-Then-Else Hi Gerd, I have tested your patch with following rules: junction=roundabout & (highway=primary | highway=primary_link) & mkgmap:option:render-roundabout!=true [0x0c road_class=3 road_speed=2 resolution 20] junction=roundabout & (highway=primary | highway=primary_link) & mkgmap:option:render-roundabout=true [0x0c road_class=3 road_speed=2 resolution 24 continue] junction=roundabout & (highway=primary | highway=primary_link) & mkgmap:option:render-roundabout=true [0x10802 resolution 20] All worked as expected, thanks! You have implemented warnings other way, than I have expected. It's good but you still can add another check: for each tag in styleOptionTags check, if tag exist in style. Or maybe if tag is used? If not, then something could be wrong - user have put option in command line, which is ignored. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
