Mike, Henning, thanks for the comments, please check my changes in http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4098 and http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4099
I hope this is okay now? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <o...@hscholland.de> Gesendet: Donnerstag, 1. Februar 2018 12:29 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Style Manual Hi Gerd, regarding tagisincomplete I would suggest to get rid of it. I can't imagine any use of it. For 2nd tagg it seems to be somehow useful. Maybe document it like ' Don't use in relation-style, is set to indicate line/poygon is part of MP-relation'. The usage in relation-styles should be checked during check-style. Henning On 01.02.2018 18:22, Gerd Petermann wrote: > Hi all, > > to be honest, I don't fully understand what mkgmap:tagsincomplete is about. > The tag is set by the OSM readers when a type=multipolygon or type=boundary > relation has a tag that is NOT evaluated by the style, > this is probably the case for many of those relations. The effect is that a > mp relation with a normal tag like name=* is treated the same as > one with exotic:unused:nonsense=*. The only case where this seems to matter > is when a relation has only the type=mulitpolygon tag. > > See this svn log message: > http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=2366 > The tag is evaluated before any style processing happens and I think it makes > no sense to evaluate or change it in style rules. > > reg: mkgmap:stylefilter: > The tag is set in the MultipolygonRelation code. It is used to decide whether > the rules in lines or in polygons should be used. > Without the tag it is likely that both are combined (rules in lines before > those in polygons). > You should not see this tag in the relations style, only in lines or > polygons, as long as you don't set it in the relations > rules. Doing this might cause trouble. > Maybe it makes sense to evaluate this tag in the lines rules, something like > # filter highways which are parts of multipolygon relations > highway=* & mkgmap:stylefilter=lines {...} > > tl;dr: > I can document these tags as e.g. "please don't set or change" > or I can try to get rid of them. What do you think? > > Gerd > ________________________________________ > Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Gerd > Petermann <gpetermann_muenc...@hotmail.com> > Gesendet: Mittwoch, 31. Januar 2018 21:22 > An: Mike Baggaley; 'Development list for mkgmap' > Betreff: Re: [mkgmap-dev] Style Manual > > Hi Mike, > > I'd rather change the code so that you don't see those tags. They are for > internal use only. > > Gerd > > ________________________________________ > Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Mike > Baggaley <m...@tvage.co.uk> > Gesendet: Mittwoch, 31. Januar 2018 20:20 > An: 'Development list for mkgmap' > Betreff: [mkgmap-dev] Style Manual > > I notice the style manual has no mention of mkgmap:stylefilter or > mkgmap:tagsincomplete in it. I see these in the output of the echotags > command when handling a relation. Can they be added to the documentation? > > Cheers, > Mike > > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev