Oops, found one bug in the patch: It should search for A01.zip, not A1.zip when 
N00W177.hgt is needed.

Attached is hgt_viewfinder-v2.patch and the new binary is here:
http://files.mkgmap.org.uk/download/428/mkgmap.jar

Gerd
________________________________________
Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Gerd 
Petermann <gpetermann_muenc...@hotmail.com>
Gesendet: Freitag, 13. April 2018 13:31
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] DEM bug at 50°N

Hi Bernhard,

thanks for the feedback and the formulars.

@all:
The attached patch allows mkgmap to find the zip names, it would find L32.zip 
when N44E006.hgt.
I hope I got all the special cases right ;-)
Some cases are very special, e.g U20.zip and GL-North.zip (Greenland) both 
contain the file N80W063.hgt and the contents of these files are different
in the two zips :O
No idea if the differences are wanted or not. I decided to search for U20.zip 
first, then for GL-North.zip.
This could be changed so that GL-North would be preferred, no idea what's 
better.

A binary is here:
http://files.mkgmap.org.uk/download/427/mkgmap.jar

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von 
Bernhard Hiller <b...@gmx.de>
Gesendet: Donnerstag, 12. April 2018 15:15:02
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] DEM bug at 50°N

Hi Gerd,

thanks, that patch works.
Bugs with simple reasons are often hard to find.

The names of the viewfinderpanoramas file look like:
- floor(Longitude/6)+31 for the number part
- (char))floor(latitude/4)+65) for the character at northern latitudes,
- 'S'+(char)(floor(latitude/4)+65) for the character at southern latitudes,
and some exceptions for Greenland, Iceland, and Antarctica.

Kind regards,
Bernhard

Am 11.04.2018 um 09:49 schrieb Gerd Petermann:
> Hi Bernhard,
>
> it turned out to be a stupid error in my code, see
> http://www.mkgmap.org.uk/websvn/revision.php?repname=gmap&revA54
> Please use r4154 (overlaps branch) or r4155 from trunk.
>
> I did not notice this because I never used the zipped files from viewfinder 
> because their names (e.g. m32.zip) give
> so little information about the content :-(
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Gerd 
> Petermann <gpetermann_muenc...@hotmail.com>
> Gesendet: Mittwoch, 11. April 2018 09:23:00
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] DEM bug at 50°N
>
> Hi Bernhard,
>
> I think the problem is that the zip files are not in one of the expected 
> formats. You should see better results if you unzip the files.
> I'll try to add support for this format now.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von 
> Bernhard Hiller <b...@gmx.de>
> Gesendet: Sonntag, 8. April 2018 20:40:23
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: [mkgmap-dev] DEM bug at 50°N
>
> According to the DEM in the map, the Rhine river some 3 km away from my
> home is at an elevation of some 2600 m asl. I do not live in the Swiss
> alps, but some 50km west of Frankfurt, just north of 50°N... The correct
> elevation is about 80m.
> Near Bingen (just south of 50°N), the Rhine is at an elevation of ~500m,
> somewhere between Assmannshausen and Lorch it ascends suddenly and very
> steeply to almost 3000m. In Cologne still at 500 m asl.
> South of 48°N, the data seem OK; but in the north, I did not find
> reasonable values - the Elbe in Hamburg above 1000m asl.
>
> I exclude a problem in the DEM data: before creating the map of Germany
> and Czechia, I tested with Hessen only. And then, the DEM values looked
> reasonable.
>
> I use mkgmap 4143. The command includes parameters for DEM:
>       --dem-poly=eas.poly ^
>       --dem=EMPATH% ^
>       --dem-dists314,4000,6000,8000,10000,15000,20000,30000 ^
> areas.poly were created by splitter in the step before,
> SET
> DEMPATH=\Maps\Development\SRTM\L32.zip,E:\Maps\Development\SRTM\M32.zip,E:\Maps\Development\SRTM\N32.zip,E:\Maps\Development\SRTM\L33.zip,E:\Maps\Development\SRTM\M33.zip,E:\Maps\Development\SRTM\N33.zip
> contains DEM data from
> http://www.viewfinderpanoramas.org/Coverage%20map%20viewfinderpanoramas_org3.htm
> (while testing with Hessen, %DEMPATH% was
> E:\Maps\Development\SRTM\M32.zip only which contains data from N48E006
> to N51E011).
>
> Or is it a matter of file size? The largest *.img file has 131256kB.
>
> Kind regards,
> Bernhard
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Attachment: hgt_viewfinder-v2.patch
Description: hgt_viewfinder-v2.patch

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to