Hi Felix, okay, now I saw the error. I am not yet sure where to fix this. We use the maxlong =8388608 (0x08000000) value in many places, and probably only in TRE it is problematic because only 3 bytes are used to store the value. If I got that right we used to write 0 instead of e.g. 0x7FFFFF, question is why nobody noticed a problem with that. Maybe Garmin software is able to handle this.
The attached patch changes the value to 0x7FFFFF. Please try if that works for you. Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Felix Hartmann <[email protected]> Gesendet: Donnerstag, 26. April 2018 14:51:23 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: Oh I'm super sorry, I got mixed up by 800 when copying the osm.pbf files- here are the real ones that fail: https://openmtbmap.org/not_compiling2.zip (other areas (geofabrik) that are failing are, Russia, Antarctica, South-America) java -ea -jar -Xmx20000M /home/contourlines/mkgmap.jar --dem=/home/contourlines/hgt/VIEW1/,/home/contourlines/hgt/SRTM1v3.0/,/home/contourlines/hgt/VIEW3/,/home/contourlines/hgt/SRTM3v3.0/ --dem-dists=9936 --dem-poly=/home/contourlines/bounds/asia.poly --max-jobs=6 --reduce-point-density=3.6 --transparent --description=openmtbmap-srtm-Asia --latin1 --draw-priority=24 --mapname=74500000 --family-id=7450 --product-id=1 --series-name=openmtbmap-srtm-ASIA --family-name=mtbmap-srtm-ASIA --overview-mapname=mapsetz --tdbfile 75400851.osm.pbf 75400853.osm.pbf 75400854.osm.pbf 75400855.osm.pbf On 26 April 2018 at 14:27, Gerd Petermann <[email protected]<mailto:[email protected]>> wrote: Hi Felix, I was not yet able to reproduce the problem. The four tiles in this zip are not even close to 180°, so I have no idea what happens. Maybe you have another version of asia.poly. I've downloaded mine a few minutes ago. Gerd ________________________________________ Von: mkgmap-dev <[email protected]<mailto:[email protected]>> im Auftrag von Felix Hartmann <[email protected]<mailto:[email protected]>> Gesendet: Donnerstag, 26. April 2018 13:39:58 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: Hi Gerd, well yes I guess it's again related to 180° - I've uploaded all the 4 tiles that do not compile here: https://openmtbmap.org/not_compiling.zip you will need the asia.poly file from geofabrik too (and the relevant hgt files - sorry I don't know which ones they are - you can get them via phyghtmap with the asia.poly (maybe antarctica.poly will be quicker - it's also messing up there). Calling mkgmap: java -ea -jar -Xmx20000M /home/contourlines/mkgmap.jar --dem=/home/contourlines/hgt/VIEW1/,/home/contourlines/hgt/SRTM1v3.0/,/home/contourlines/hgt/VIEW3/,/home/contourlines/hgt/SRTM3v3.0/ --dem-dists=9936 --dem-poly=/home/contourlines/bounds/asia.poly --max-jobs=6 --reduce-point-density=3.6 --transparent --description=openmtbmap-srtm-Asia --latin1 --draw-priority=24 --mapname=74500000 --family-id=7450 --product-id=1 --series-name=openmtbmap-srtm-ASIA --family-name=mtbmap-srtm-ASIA --overview-mapname=mapsetz --tdbfile 7*.osm.pbf On 26 April 2018 at 10:50, Gerd Petermann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> wrote: Hi Felix, I think the assertions have one big disadvantage: One never knows the tile that was processed. Attached is a patch that should report the bad tile(s) and maybe fixes the problem, but I think we have to find the place in the source that produces the invalid bounds. At the moment I see only one possibility: A tile that has minlong on +180°. So if you have the problem tile and you are able to reproduce the crash with the default style please post the details. Gerd ________________________________________ Von: mkgmap-dev <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> im Auftrag von Felix Hartmann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> Gesendet: Donnerstag, 26. April 2018 10:30:21 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: okay I kinda guessed so - because it produced way more tiles before the crash.... On 26 April 2018 at 10:21, Gerd Petermann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>> wrote: Hi Felix, this is a different error in a different source. I'll have a look now. I don't need the file. Gerd ________________________________________ Von: mkgmap-dev <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>> im Auftrag von Felix Hartmann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>> Gesendet: Donnerstag, 26. April 2018 10:18:10 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: It's not fixed yet with the newest mkgmap version - still getting: java.lang.AssertionError: 8388608 at uk.me.parabola.imgfmt.app.BufferedImgFileWriter.put3s(BufferedImgFileWriter.java:143) at uk.me.parabola.imgfmt.app.trergn.TREHeader.writeFileHeader(TREHeader.java:165) at uk.me.parabola.imgfmt.app.CommonHeader.writeHeader(CommonHeader.java:73) at uk.me.parabola.imgfmt.app.trergn.TREFile.writePost(TREFile.java:349) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:351) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) I'm compiling it again now with --keep-going to find the offending .osm.pbf tile and will upload that in a couple of hours. On 25 April 2018 at 20:28, Felix Hartmann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>> wrote: I'm trying it right now (Asia takes a couple of hours however) - I've removed the patch nevertheless. On 25 April 2018 at 20:20, Gerd Petermann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>> wrote: Hi Felix, I don't think that the patch changes this. As Ticker suggested I've removed the assertions introduced with r4167. Please try with r4179. Gerd ________________________________________ Von: mkgmap-dev <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>> im Auftrag von Felix Hartmann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>> Gesendet: Mittwoch, 25. April 2018 19:03:54 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: oh yes - I still use the dem-empty.patch from you - I will remove it and try how it behaves without that one. (besides it I'm using minSizePolygon = props.getProperty("min-size-polygon", 14); (instead of 8) since long long time, but I'm sure that's no cause for the error here). Felix On 25 April 2018 at 18:57, Gerd Petermann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>>> wrote: Hi Felix, it seems you use a version of MapBuilder that doesn't match the current source in trunk. Is that possible? If yes, please post your version. Gerd ________________________________________ Von: mkgmap-dev <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>>> im Auftrag von Felix Hartmann <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>>> Gesendet: Mittwoch, 25. April 2018 18:17:30 An: Development list for mkgmap Betreff: [mkgmap-dev] Current mkgmap version has another java.lang.AssertionError: java.lang.AssertionError: minlong=-8388608 at uk.me.parabola.imgfmt.app.trergn.TREFile.setBounds(TREFile.java:359) at uk.me.parabola.imgfmt.app.map.Map.setBounds(Map.java:162) at uk.me.parabola.mkgmap.build.Ma<http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma>pBuilder.processInfo(MapBuilder.java:1000) at uk.me.parabola.mkgmap.build.Ma<http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma><http://uk.me.parabola.mkgmap.build.Ma>pBuilder.makeMap(MapBuilder.java:288) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) I'm sure back 30-40 versions mkgmap had no problems here - I basically did not change my style (only removed one resolution) - and the data is the same. Happens on Asia continent map dem/contourline creation. java -ea -jar -Xmx20000M /home/contourlines/mkgmap.jar --dem=/home/contourlines/hgt/VIEW1/,/home/contourlines/hgt/SRTM1v3.0/,/home/contourlines/hgt/VIEW3/,/home/contourlines/hgt/SRTM3v3.0/ --dem-dists=9936 --dem-poly=/home/contourlines/bounds/asia.poly --max-jobs=6 --reduce-point-density=3.6 --transparent --description=openmtbmap-srtm-Asia --style-file=srtm --latin1 --draw-priority=24 --mapname=74500000 --family-id=7450 --product-id=1 --series-name=openmtbmap-srtm-ASIA --family-name=mtbmap-srtm-ASIA --overview-mapname=mapsetz --tdbfile 7*.osm.pbf -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list [email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list [email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list [email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>><mailto:[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list [email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list [email protected]<mailto:[email protected]> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
tre_maxlong.patch
Description: tre_maxlong.patch
_______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
