Hi Steve, after committing the tags3.patch with r4182 yesterday I wondered why I did not find a unit test which shows the problem that I fixed with r3822: http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3822
I've now added that test to make sure that the new code works. It does :) I got curious and tried RuleIndex.java from r3820 and was surprised to find that it alse passes all tests. In the end the code in RuleIndex was okay, the error was in the code that arranged expressions and you fixed that recently. The good thing is that the old code was even better than that in tags3.patch, so I've created a new patch which is basically a revert of the changes in r3822 and r4182. Please review and try to find a unit test that would not work with that patch. Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Steve Ratcliffe <[email protected]> Gesendet: Donnerstag, 26. April 2018 23:33:53 An: [email protected] Betreff: Re: [mkgmap-dev] patch to improve style throughput Hi Gerd > here is the improved version of the patch. It reduces the number of rules to > be checked a bit more. Thanks, that seems to work well. Steve _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
tags4.patch
Description: tags4.patch
_______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
