Hi

> Update, previous version had some errors, conclusion is the same

OK, Thanks that is great.

So I don't think that there wasn't really intended to be a change to
routing in that branch, but there was an experimental option that was
added, and then removed, with a couple of lines of code omitted,
probably unintentionally.  This is what causes the failure in NodCheck
and maybe causes the failure on the device too.

The attached patch restores the functionality and NodCheck does not
crash on the result

There is a pre-compiled jar there: http://files.mkgmap.org.uk/download/484/mkgmap.jar

It may interact or interfere with the routing island removal code that
was also made in that branch.  I've no idea if it does or not, it is
just something to check.

Steve
Index: src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java
===================================================================
diff --git a/trunk/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java b/trunk/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java
--- a/trunk/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(revision 4555)
+++ b/trunk/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(working copy)
@@ -1499,6 +1499,13 @@
 	 */
 	private void addRoadAfterSplittingLoops(ConvertedWay cw) {
 		Way way = cw.getWay();
+		
+		if (routable) {
+			// make sure the way has nodes at each end
+			way.getPoints().get(0).incHighwayCount();
+			way.getPoints().get(way.getPoints().size() - 1).incHighwayCount();
+		}
+
 		// check if the way is a loop or intersects with itself
 
 		boolean wayWasSplit = true; // aka rescan required
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to