Hi Gerd, In my view it does not make sense to make the option only operate on the new checks (land within land) leaving sea within sea always checked. I think that either checks are wanted or they are not, hence the option switches on and off all the checks. It seems overkill to go for --check=[land|sea].
To me, because the default behaviour statement is on the multipolygon value, not the generate-sea option, the docs indicate that multipolygon is the default when --generate-sea is specified without a value, not that --generate-sea=multipolygon is on by default. If --generate-sea=multipolygon is the default, how is it switched off if sea processing is not needed? The minor changes look fine to me. Looks like I had got too used to editing style files with its & and | rather than the Java && and ||! Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:[email protected]] Sent: 10 February 2021 08:47 To: Development list for mkgmap <[email protected]> Subject: Re: [mkgmap-dev] Fix Sea Patch Hi Mike, if I got that right there is no impact on the PrecompSeaGenerator as that doesn't execute this part of SeaGenerator. There is also no impact on processing when --precomp-sea is used. However, now the patched code only performs any check when new parameter --check is given. Is that intended? Ticker suggested to add an option for the additional checks. The doc says that --generate-sea=multipolygon is the default, this is also true with --precomp-sea. Not sure what is confusing you? I've made some minor changes to the code to reduce complexity, but didn't check the details of the new code. Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Mike Baggaley <[email protected]> Gesendet: Montag, 8. Februar 2021 15:58 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Fix Sea Patch HI Gerd, I don't have a build that includes the PrecompSeaGenerator, but I would expect the impact to be the same as for in-line sea generation: an increase in execution time if /check is specified with a reduction if it is not specified. I'm not quite clear what happens if you specify --precomp-sea, but don't specify --generate-sea. The help only says that --precomp-sea can be combined with --generate-sea but doesn't say what happens if you don't. (Does it switch on --generate-sea=multipolygon?) I think the order of the options in the documentation is not ideal either - I would think --generate-sea should come first, followed by --coastline-file and that followed by --precomp-sea. Happy to tweak this. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:[email protected]] Sent: 07 February 2021 17:36 To: Development list for mkgmap <[email protected]> Subject: Re: [mkgmap-dev] Fix Sea Patch Hi Mike and Ticker, do you expect an impact on the PrecompSeaGenerator? Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Ticker Berkin <[email protected]> Gesendet: Sonntag, 7. Februar 2021 18:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Fix Sea Patch Hi Mike / Gerd This patch seems fine to me. Ticker _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
