Hi Steve,

Please review: 
I've noticed that 
log.isLoggable(Level.WARNING)
always returns true when I don't use the -Dconfig.logging option for JRE . This 
is unexpected as calls to 
log.warn(...)
don't produce any output in this case.

The attached simple patch seems to fix this but I don't really understand the 
code.
Maybe you forgot this change in 
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=233 ?

In class MultiPolygonRelation we have quite a lot of methods which is meant to 
be skipped if logging is not enabled but because of this bug(?) the code is 
executed sometimes, maybe with side effects that I don't yet fully understand.

Gerd

Attachment: logger.patch
Description: logger.patch

_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to