Hi Gerd, No problems with downgrading the message to info (I'd be happy to remove it completely, as it does seem a little unnecessary), but stopping if the directory is not OK will require throwing an ExitException and adding catches to TypCompiler and MapMaker (I think), so I propose to remove CommandArgs from the patch (see updated patch attached) and create a new one for it and its related changes. I assume you would want both the "Unable to create output directory! Using default directory instead" and "The --output-dir parameter must specify a directory. The parameter is being ignored, writing to default directory instead" messages changing so that the default directory is not used and program execution stops. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:[email protected]] Sent: 11 April 2021 16:58 To: Development list for mkgmap <[email protected]> Subject: Re: [mkgmap-dev] Yet More Logging Hi Mike, not sure about the changes in CommandArgs. I'd prefer an info message for the new directory and exit with error if output-dir is not OK. For me it's normal to remove the directory and let mkgmap create it. If that fails for whatever reason mkgmap should just stop. Rest looks good. Gerd ________________________________________ Von: mkgmap-dev < <mailto:[email protected]> [email protected]> im Auftrag von Mike Baggaley < <mailto:[email protected]> [email protected]> Gesendet: Sonntag, 11. April 2021 17:44 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Yet More Logging Hi Gerd, Here's the next patch. Hopefully should only need a couple more patches to package up the remainder of the changes. Cheers, Mike
yetmorelogging.v2.patch
Description: Binary data
_______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
