URL:
<http://savannah.nongnu.org/bugs/?17456>
Summary: shell commands broken
Project: mldonkey, a multi-networks file-sharing client
Submitted by: orbit
Submitted on: Thursday 08/17/2006 at 23:53
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Assigned to: None
Open/Closed: Open
Release:
Release: 2.7.7
Operating System: Linux
Binaries Origin: CVS / Self compiled
CPU type: None
_______________________________________________________
Details:
case 1:
allowed_commands = [
(df, df);
(ls, "ls incoming");]
allow_any_command = false
> ! ls
---------------- Exited with code 1
OK
> ! ls /
For arbitrary commands, you must set 'allowed_any_command'
OK
> ! ls incoming
For arbitrary commands, you must set 'allowed_any_command'
False, this should work
> ! "ls incoming"
False, should be the same as last
> ! mount
False, there should be the error message
-------------------------------------------
case 2:
allowed_commands = [
(df, df);
(ls, "ls incoming");]
allow_any_command = true
> ! ls
---------------- Exited with code 1
OK
> ! ls /
/:
bin
boot
...
OK
> ! ls incoming
---------------- Exited with code 1
OK
> ! "ls incoming"
False, should be the same as last
> ! mount
False, this should work when allow_any_command = true
-------------------------------------------
So allow_any_command option doesn't work
and ! doesn't work correct
anyway, mldonkey gets the password uncrypted so this would be a major
security risk
if it would work ;)
I suggest remove allow_any_command or remove shell commands completely. I
doubt someone will miss this feature.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?17456>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
_______________________________________________
Mldonkey-bugs mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/mldonkey-bugs
