Hi there Piyush,
Thanks for the contribution. Before we merge this, could I ask you to add some
tests? Take a look at the tests I wrote for the LSHSearch class's copy/move
constructors and assignment operators:
https://github.com/rcurtin/mlpack/blob/bindings/src/mlpack/tests/lsh_test.cpp#L839
Thanks,
Ryan
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/824#issuecomment-264879012
_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
