Okay, I've opened a PR on your branch
(https://github.com/thejonan/mlpack/pull/1) to add some tests to this. Sorry
for the slowness on this, it took a while to find the time.
Before merging this upstream with Armadillo, could I ask you to add a version
of sort() that takes in an input matrix and a dimension on which to sort
(either column-wise or row-wise), just like arma::sort() for dense matrices?
http://arma.sourceforge.net/docs.html#sort
I already have some simple tests written for that, so you can just uncomment
those. After that this will be ready to merge and then I can make the minor
changes necessary to submit a patch upstream (I'll CC you on the email when
that gets done).
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/808#issuecomment-264897676
_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
