Hi there @MikeLing, thanks for the contribution.  Unfortunately I'm not totally 
sure what this overload does since there are no comments.

Ideally, for multidimensional discrete distribution support, the API shouldn't 
change, it should just be a generalization.  Note that now, when you call 
`DiscreteDistribution::Probability()`, the parameter `const arma::vec& 
observation` must be a one-dimensional vector.  The idea is to generalize this, 
so that a discrete distribution can have many dimensions.

The distribution should have zero correlation across dimensions, so if I have 
the vector "a,b" then P(a,b) = P(a)P(b).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/830#issuecomment-268355909
_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack

Reply via email to