rcurtin commented on this pull request.
> + end(obj.end),
+ maxVals(obj.maxVals),
+ minVals(obj.minVals),
+ splitDim(obj.splitDim),
+ splitValue(obj.splitValue),
+ logNegError(obj.logNegError),
+ subtreeLeavesLogNegError(obj.subtreeLeavesLogNegError),
+ subtreeLeaves(obj.subtreeLeaves),
+ root(obj.root),
+ ratio(obj.ratio),
+ logVolume(obj.logVolume),
+ bucketTag(obj.bucketTag),
+ alphaUpper(obj.alphaUpper),
+ left(obj.left),
+ right(obj.right)
+{ /* Nothing to do. */ }
This doesn't actually copy the left and right child nodes, but your copy
operator does. Can you fix that please?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/826#pullrequestreview-14477740_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
