rcurtin commented on this pull request.
> @@ -43,8 +43,6 @@ size_t
> RPlusTreeDescentHeuristic::ChooseDescentNode(TreeType* node,
node->Child(bestIndex).Bound();
bound |= node->Dataset().col(point);
- success = true;
-
The change that you've made means that during this loop, `success` is not
reinitialized to `true` each iteration. So this introduces a bug.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/840#pullrequestreview-14480154_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
