Many thanks for all your kind support, you are great On Fri, Dec 28, 2018 at 8:37 PM Ryan Curtin <[email protected]> wrote:
> On Fri, Dec 28, 2018 at 11:08:41AM +0100, Frodo Jedi wrote: > > Hi Ryan, > > thanks again ;-) > > So yes, if I type import mplack this time there is no error. > > Great to hear it works. I'll open a PR with the fix shortly, and it > should be merged soon. Thanks for the report, and I'm glad we were able > to get it fixed! > > > Then I run make -j4 (as normal user, not with sudo) and then I run sudo > > make install. No error was detected so I guess now everything should > work. > > > > I was wondering, how can I fully check that everything is solved and > works > > at 100%? Any further test? > > As far as the installation goes, there's nothing else to be tested. > Actually for my fixes, I'd like to also have CMake fail on installation > if setup.py doesn't install the Python bindings correctly. That will > also be a part of the PR I put together. > > For testing the software itself, you can run 'make test' and it will > build and run all the tests. > > -- > Ryan Curtin | "She fell..." > [email protected] | - Ludvig >
_______________________________________________ mlpack mailing list [email protected] http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
