Hey, I made the changes as suggested by you, if possible have a look and let me know where should I improve.
Regards, Gopi On Mon, Apr 12, 2021 at 3:06 AM Omar Shrit (Google Docs) < [email protected]> wrote: > Omar Shrit added comments and suggestions to the following document > mlpack: Replacing boost::spirits > > <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5Q&ts=60736bf6&usp=comment_email_document&usp_dm=false> > *New* > 2 comments, 1 suggestion > Comments > We need to add armadillo’s csv parser(diskio_meat.hpp) with proper > attribution wherever required into mlpack’s codebase. I suggest we don’t > touch this file and create a new file to handle non-numeric data. The > boost::spirit parser is contained completely in only two file: > src/mlpack/core/data/load_csv.hpp src/mlpack/core/data/load_csv.cpp We can > rewrite the above-mentioned two files to handle categorical data. As these > files are already well implemented we can use the same interface. > [image: User profile picture Omar Shrit] Omar ShritNew > You can develop your ideas here, you can write them into paragraphs and > then add tasks into bullet points > Reply > <reply%20%3cd+aorgprczkbi6zhx-z438-5dpixhin8ioauoafdz4ldjvo7x6zjozvwmruqhhx-ukcmhcjxlgcqxchktlvvkc2_pqbvxyc0wxy5u-hnc8vainohibmmqk2w83sezbctphrcmc988c4...@docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits> > Open > <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5E&usp=comment_email_discussion&usp_dm=false&ts=60736bf6> > in the current file structure > [image: User profile picture Omar Shrit] Omar ShritNew > After this paragraph you can add more details about how you are going to > represent the results, benchmark, and include the `Extra work` section in it > Reply > <reply%20%3cd+aorgpre9m-wfzyjz746lfixajyunj33ccxflttbrmnkmo_lgt-oilk5zm2dvju3-pvgaltznpnddibyukjnusccxpnjaucgzzqtx9mzzzt_ojlqgxugx6lddl9d815dat1qb1ocve...@docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits> > Open > <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5Q&usp=comment_email_discussion&usp_dm=false&ts=60736bf6> > Suggestions > [image: User profile picture Omar Shrit] Omar ShritNew > Delete: “You can refer to issue #2646 to take a look there.” > Reply > <reply%20%3cd+aorgprdz_ifdj2z1c83m83kf2mcfov2u4kmdwbklhd3xarxbzghgh29tpeh7f8w89pyz1mdma3y3vw-0wyjnxhdqdds8eu-1ajaem9vmkuojb7aighfxgoxv-wenos8au45-3ec9d...@docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits> > Open > <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5A&usp=suggestion_email_discussion&usp_dm=false&ts=60736bf6> > > Google LLC, 1600 Amphitheatre Parkway, Mountain View, CA 94043, USA > > You have received this email because you are a participant in the updated > discussion threads.Change what Google Docs sends you. > <https://docs.google.com/document/u/118255091348362360280/docos/notify?ouid=118255091348362360280&id=1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE&title=mlpack:+Replacing+boost::spirits>You > can not reply to this email. >
_______________________________________________ mlpack mailing list [email protected] http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
