On Sun, July 3, 2011 10:01 pm, Dan Dennedy wrote:
> 2011/7/3 Maksym Veremeyenko <ve...@m1stereo.tv>:
>> Hi,
>>
>> playing files in a loop mode in melted cause a leak of file descriptors
>> that
>> seen well from /proc/<process id>/fd/<file no>.
>>
>> the problem comes from avformat's producer re-open code that lost
>> release of
>> audiostream context.
>>
>> attached patch fix this behaviour...
>
> This patch is wrong in a couple of ways. It completely alters the
> locking mechanisms, and I will be surprised if it works under
> multi-threaded access such as with kdenlive or with parallel consumer.
> Your attempt to refactor to common code is noble but naive with
> respect to the locking requirements, which are different depending
> upon the state of the locks when these similar actions are invoked.
> Secondly, it breaks the user-selected audio and video tracks because
> in producer_open() they are reset to their defaults. That is why they
> were saved before producer_open() and re-applied afterwards.

updated patch attached....

-- 
________________________________________
Maksym Veremeyenko

Attachment: 0001-fix-a-audiostream-leak-in-producer-reopen.patch
Description: Binary data

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel

Reply via email to