On Mon, Sep 5, 2011 at 9:23 AM, Dan Dennedy <[email protected]> wrote: > On Mon, Sep 5, 2011 at 4:14 AM, j-b-m <[email protected]> wrote: >> Hi Dan, >> >> Moving this discussion from the Kdenlive bug tracker (1) to the mlt-dev >> mailing list since it may be useful one day to find it here... >> >> First, your last change to producer_melt does not work, since it is >> placed just before the track is inserted, so we still get the crash. >> mlt_multitrack_count must be called after the track was inserted to get >> the correct count, see my patch below. > > Agreed, strange that my test did not fail. > >> Then, I understand and I agree that the framework should not contain >> module specific code. However, in that case, my proposed patch (on >> Kdenlive's bug tracker) to mlt_multitrack solved the problem once for >> all for everyone. > > I realize that advantage, and it is something that has been bothering > me to consider making an exception with a strong comment. I have also > been thinking about about using events, so the avformat producer can > detect when it has been added to a multitrack, but it gets ugly with a > few events linked together.
I thought about this, and what is really needed is a way to broadcast an event across all connected services. Then, I could add a track-added event to multitrack, and the avformat producer would listen for it and adjust its cache size when received. However, that is going to require some intensive analysis and work, and I have to tend to some other things in the near term. So, I applied your suggested patch with a TODO comment and reverted the previous changes to melt and xml producers. -- +-DRD-+ ------------------------------------------------------------------------------ Malware Security Report: Protecting Your Business, Customers, and the Bottom Line. Protect your business and customers by understanding the threat from malware and how it can impact your online business. http://www.accelacomm.com/jaw/sfnl/114/51427462/ _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
