On Thu, Sep 8, 2011 at 2:23 PM, j-b-m <[email protected]> wrote: > On Thursday 08 September 2011 13:46:49 Dan Dennedy wrote: >> On Thu, Sep 8, 2011 at 1:42 PM, j-b-m <[email protected]> wrote: >> > On Thursday 08 September 2011 13:29:01 Dan Dennedy wrote: >> >> On Thu, Sep 8, 2011 at 12:19 PM, j-b-m <[email protected]> > wrote: >> >> > The problem now is that this fix breaks the locale conversion of >> >> > geometry >> >> > strings which previously seemed to work on a random basis. I am >> >> > not >> >> > exactly >> >> >> >> What do you mean by "locale conversion?" Strictly speaking, MLT does >> >> not support converting a project from one locale to another. >> > >> > Sorry, I did not mean locale conversion, just reading in a locale with a >> > comma separator. >> > >> >> There are a few places throughout the code including mlt_geometry.c >> >> where strtod_l() is NOT used where available. mlt_geometry is not >> >> currently associated with mlt_properties where locale is stored. So, >> >> either I need to change API of mlt_geometry to take a locale, or I >> >> need to bite the bullet of adding a new rect property type and >> >> comprehensive property animation. >> > >> > We use mlt_geometry in Kdenlive to make frei0r effects keyframable, like >> > for example the corner effect. So, with a french or german locale, we >> > end up with what is visible in the test.mlt file attached in my >> > previous mail: >> > >> > <property name="Corner 1 X">0=0,333333</property> >> > >> > And MLT does not correctly read it since as you said mlt_geometry does >> > not support locale... ouch. >> >> Another option is to go back to using the XML LC_NUMERIC to set the >> process global numeric locale instead of using strtod_l. > > Oh I just realized that this only happens when trying to read a project using > a locale different than your system. I previously thought this would > completely break geometry params for french users... > > So in fact it's not that bad... Yes, I will see if we can change the process > locale when opening a project in Kdenlive, and do it also in case of > rendering.
I do not want to add onto the mlt_geometry API just yet. Therefore, I do not want to try to fix this for the next release. Then, after this next release I will work on property animation for mlt_properties and add new mlt_property types like rect, color, and time. I will, however, address a problem I noticed in composite with some sprintf/scanf using comma-delimited floats. -- +-DRD-+ ------------------------------------------------------------------------------ Why Cloud-Based Security and Archiving Make Sense Osterman Research conducted this study that outlines how and why cloud computing security and archiving is rapidly being adopted across the IT space for its ease of implementation, lower cost, and increased reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/ _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
