2011/12/21 Gleb Smirnoff <[email protected]>: > Dan, > > On Mon, Dec 19, 2011 at 11:22:34PM -0800, Dan Dennedy wrote: > D> 2011/12/14 Gleb Smirnoff <[email protected]>: > D> > Dan, > D> > > D> > FreeBSD recently got support for xlocale.h. To fix build of > D> > MLT I have prepared the attached patch. > D> > > D> > However, the patch isn't perfect. IMHO, it'll be better > D> > to autodetect presense of param.h at configure stage. Since > D> > MLT configure isn't autotool-generated, I failed to add > D> > param.h detection code there. I liked your configure, btw :) > D> > > D> > May be you have idea about fixing this. Here is some info > D> > on including param.h: > D> > > D> > > http://www.freebsd.org/doc/en/books/porters-handbook/porting-versions.html > D> > > D> > If you need, I'd can test your patches on newer FreeBSD > D> > versions. > D> > D> Hi, thank you for this contribution. > D> Can you please test my attached patch that adds param.h detection to > D> configure? Beware, it includes your part as well. > > I have fixed your patch in several places, now with it mlt builds > correctly on recent FreeBSD. My changes to your patch: > > - A typo: param.h, not xparam.h
oops that was a remnant of an intentional negative test because sys/param.h exists on Linux as well. > - Add "-n" to the echo that initiates config.mak. Perfectionism! > - Removed "$CFLAGS" from gcc test run. At this stage CFLAGS is empty var, > but shell still passes and empty argument that gcc treats as a file > that it should open, thus failing. maybe because I put it in "". I wanted to retain CFLAGS set through an environment variable, but perhaps that is not important in this context. > - Made [ compare integer values, not strings. Perfectionism. > - In mlt_property.h use #ifdef HAVE_SYS_PARAM_H, not #ifdef __FreeBSD__, > since we made all the above changes to configure and Makefile for the > sake of having this parameter. ok > Here is patch attached. > > btw, concerning portability of MLT to FreeBSD. There are several patches > in our port, you can see them here: > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/multimedia/mlt/files/ > > It'll be nice if number of portability patches reduces in next MLT > release, so that vendor (you) review them and include in your > development. I can give a hand here. I will try to merge those, but I might not check that location periodically. Often times I receive patches from FreeBSD and NetBSD folk on the mailing list or SourceForge tracker, which I prefer. I do not have the patience to find and review every distro's package changes. > Also, the git snapshot doesn't build now: > > g++ -O -Wall -DPIC -O2 -pipe -fno-tree-dominator-opts -fno-tree-pre > -ffast-math -DUSE_MMX -DUSE_SSE -DUSE_SSE2 -g -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -DARCH_X86_64 -fPIC -pthread -Wall -DPIC -O2 -pipe > -fno-tree-dominator-opts -fno-tree-pre -ffast-math -DUSE_MMX -DUSE_SSE > -DUSE_SSE2 -g -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -fPIC > -pthread -I../.. -Wall -DPIC -O2 -pipe -fno-tree-dominator-opts > -fno-tree-pre -ffast-math -DUSE_MMX -DUSE_SSE -DUSE_SSE2 -g > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -fPIC -pthread > -Wno-deprecated -Wno-multichar -fno-rtti -D__LINUX_OSS__ -c -o RtAudio.o > RtAudio.cpp > RtAudio.cpp:6376:23: error: soundcard.h: No such file or directory > RtAudio.cpp: In member function 'virtual unsigned int > RtApiOss::getDeviceCount()': > ... > > soundcard.h seems to be a Linux-only interface. If this module isn't No, it is for OSS. The FreeBSD wiki page http://wiki.freebsd.org/Sound led me to believe FreeBSD led me to believe it still supports OSS. > critical for MLT operation, it can be disabled on FreeBSD, if you > don't have resources to make it portable. OK, I will disable this plugin when not Linux, Windows, or OS X. -- +-DRD-+ ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
