On Wed, Jul 4, 2012 at 10:57 AM, Maksym Veremeyenko <[email protected]> wrote:
> 03.07.12 18:50, Dan Dennedy написав(ла):
>
>> On Tue, Jul 3, 2012 at 5:42 AM, Maksym Veremeyenko<[email protected]>
>> wrote:
>>>
>>> Hi,
>>>
>>> attached patch USTA output with current clip start time and playlist
>>> duration. Two more parameters helps detect global playlist playback and
>>> remaining time.
>>>
>>> that breaks ABI with previous version so lib number should be
>>> incremented.
>>
>>
>> ok
>>
>>> another issue is older mvcp client will not support status reading from
>>> newer version - they will reject to parse USTA output due to increased
>>> number of entries.
>>
>>
>> I think we should make a new command USTATUS that also includes a
>> version or new text format that affords extensibility.
>>
>
> if you plan to reject this patch, i can implement USTA2 and STATUS2 commands
> with appropriate mvcp_status2 but that will require duplicating
> mvcp_status2.[c|h] and mvcp_notifier2.[h|c]...
I do not want to reject it and make a new command. Instead, I would
like to establish a pattern to make the client backwards compatible
and adapt to future additions at the protocol level. So, instead of
if ( 19 == r || 17 == r )
I think we should make it like:
if ( r >= 17 ) // if valid response
...
if ( r >= 17 )
status->start = atoi( mvcp_tokeniser_get_string( tokeniser, 17 ) );
else
status->start = -1;
if ( r >= 18 )
status->dur = atoi( mvcp_tokeniser_get_string( tokeniser, 18 ) );
else
status->dur = -1;
--
+-DRD-+
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Mlt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mlt-devel
