On Sun, Sep 2, 2012 at 6:09 PM, Dan Dennedy <[email protected]> wrote: > On Sun, Sep 2, 2012 at 12:51 PM, j-b-m <[email protected]> wrote: >> Hello Dan, >> >> You made a change to the xml producer that causes problems in Kdenlive ( for >> example http://kdenlive.org/mantis/view.php?id=2711 ). >> >> The commit is the following one: >> https://github.com/mltframework/mlt/commit/89ff4d149a0ac54deab4057178678b68bef1e92d > > Do you understand the reason for the change? If you have an xml file > that contained simply a producer element under the root, then it would > overwrite the producer's resource property with the filename of the > xml file, which causes problems for the producer or for > re-serialization! > >> In Kdenlive, we sometimes use the "resource" property of a clip to create a >> duplicate of the producer or for other reasons. >> >> Since the mentioned commit, the "resource" property of an xml playlist is not >> set anymore (it defaults to "<playlist>"), and it seems it is not possible >> anymore to get the location of the playlist file. >> >> What do you think about it? The "resource" property is used in several >> producers, and it seems to me that it would be good to keep it working in the >> xml producer. > > Then, the resource attribute belongs on the root element and not > overwriting some other object's resource property. I will see how to > make that change. >
Oh, wait, sorry, there is no concept of a "root" or even a distinct producer for the xml producer as it returns the last producer constructed during deserialization. If we check if resource is "<playlist>" or "<tractor>" etc then we would not be supplying the xml file's name anywhere when it is just a producer. I think we could set a new property named "_xml_resource" (prefaced with the underscore to prevent it from being serialized). -- +-DRD-+ ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
