Hello. The recent change to deinterlace filter (1) breaks playing of some clips in timeline in Kdenlive.
I do not really understand why, but playing in the clip monitor works, while playing the timeline monitor gives a black screen on some clips. However, looking at the code, I could fix the black screen problem with the following patch. This patch seems to make sense, because in current git we call: mlt_frame_get_image( frame, image, format, width, height, writable ); twice in a row (at line 242 and 248). (1) https://github.com/mltframework/mlt/commit/cf73314203ff98894b2d91a99354aaff69a53ad3 regards jb _______________________________________________________________________________ diff --git a/src/modules/xine/filter_deinterlace.c b/src/modules/xine/filter_deinterlace.c index 802ec75..5f053a7 100644 --- a/src/modules/xine/filter_deinterlace.c +++ b/src/modules/xine/filter_deinterlace.c @@ -239,9 +239,8 @@ static int filter_get_image( mlt_frame frame, uint8_t **image, mlt_image_format method = DEINTERLACE_ONEFIELD; // Get the current frame's image - error = mlt_frame_get_image( frame, image, format, width, height, writable ); progressive = mlt_properties_get_int( properties, "progressive" ); - if ( !error && !progressive ) + if ( !progressive ) { // OK, now we know we have work to do and can request the image in our format *format = mlt_image_yuv422; ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
