On Sat, Sep 22, 2012 at 6:13 AM, j-b-m <[email protected]> wrote:
> On Wednesday 19 September 2012 23:14:51 Dan Dennedy wrote:
>> On Wed, Sep 19, 2012 at 1:41 PM, j-b-m <[email protected]> wrote:
>> > On Sunday 02 September 2012 18:09:46 Dan Dennedy wrote:
>> >> On Sun, Sep 2, 2012 at 12:51 PM, j-b-m <[email protected]>
> wrote:
>> >> > Hello Dan,
>> >> >
>> >> > You made a change to the xml producer that causes problems in Kdenlive
>> >> > (
>> >> > for example http://kdenlive.org/mantis/view.php?id=2711 ).
>> >> >
>> >> > The commit is the following one:
>> >> > https://github.com/mltframework/mlt/commit/89ff4d149a0ac54deab405717867
>> >> > 8b6
>> >> > 8bef1e92d
>> >>
>> >> Do you understand the reason for the change? If you have an xml file
>> >> that contained simply a producer element under the root, then it would
>> >> overwrite the producer's resource property with the filename of the
>> >> xml file, which causes problems for the producer or for
>> >> re-serialization!
>> >
>
>> I believe I fixed this in the latest git commit.
>
> Hello Dan,
>
> We still have problems related to this in Kdenlive. In some places in
> Kdenlive, we generate xml .mlt files looking like this:
>
>
> <mlt>
> <producer id=producer0>
> (...)
> </producer>
> <playlist id=playlist0>
> <entry producer="producer0" in="0" out="20"/>
> </playlist>
> </mlt>
>
> You can notice that there is a playlist but no tractor (the MLT doc seems to
> say it's ok). Loading of such files in Kdenlive is broken with current
> xml_producer. Instead of inserting the .mlt file, its playlist is inserted
> directly inside Kdenlive, without any reference to the .mlt file.
>
> Would you agree to fix it using the patch below?
I was thinking this might be needed when I wrote the previous change.
I accepted your proposal and expanded upon it in the latest commit.
> regards
>
> jb
>
>
> ------------------------------------------------------------------------
>
> diff --git a/src/modules/xml/producer_xml.c b/src/modules/xml/producer_xml.c
> index 2baec97..d518572 100644
> --- a/src/modules/xml/producer_xml.c
> +++ b/src/modules/xml/producer_xml.c
> @@ -1734,7 +1734,7 @@ mlt_producer producer_xml_init( mlt_profile profile,
> mlt_service_type servtype,
> if ( getenv( "MLT_XML_DEEP" ) == NULL )
> {
> // Now assign additional properties
> - if ( is_filename && mlt_service_identify( service ) ==
> tractor_type )
> + if (( is_filename ) && ( mlt_service_identify( service
> ) == tractor_type || mlt_service_identify( service ) == playlist_type ))
> mlt_properties_set( properties, "resource",
> data );
>
> // This tells consumer_xml not to deep copy
>
--
+-DRD-+
------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Mlt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mlt-devel
