>> >> Ahhh, I finally found the problem! The bug is triggered by an optimization >> flag: -O2 >> >> When using the build script, we configure MLT with --enable-debug, which >> disables optimization flags. However, when manually compiling MLT not in >> debug >> mode, the "-O2" flag is set and triggers the bug on my system (Ubuntu 12.10, >> gcc 4.7.2). >> >> I was also able to reproduce the problem on an OpenSuse 12.2 with gcc 4.7.1. >> >> Not sure but it looks like with this optimization, the aspect ratios are >> sometimes wrongly rounded, giving for example 1,777777 instead of 1,777778. > >Thanks for finding this. My main workstation (based on ubuntu 11.10) >has gcc 4.6.1, and while I usually use --enable-debug, I did not >reproduce it without. However, I am concerned about how your patch >changes some of the math, which seems heavy-handed for a rounding >error. Does it fix other cases of mismatching sample aspect rates? Do >you think I should trust your judgement/testing and apply it?
Well, I also have doubts about how exactly the bug is triggered by this optimization flag. My patch also fixes other mismatching sample rates, but I am almost sure that the bug was not there in previous versions of MLT, so before we change anything I want to try to find out which commit broke this stuff. I probably won't have time for this before friday, will let you know as asap. Regards jb ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
