On Fri, Dec 14, 2012 at 6:58 PM, Brian Matherly <[email protected]> wrote: >>> There is an interesting behavior when a filter that uses a geometry is > >> attached to a clip. See the following example: >>> >>> >>> melt colour:blue out=100 colour:red out=200 -attach >> dynamictext:"#timecode" >> geometry="0=0/0:100%x100%:100;100=400/500:100%x100%:100" >>> >> >> watermark alone works as expected: >> >> melt -silent colour:blue out=100 colour:red out=200 -attach >> watermark:demo/watermark1.png >> composite.geometry="0=0/0:100%x100%:100;100=400/500:100%x100%:100" >> >> diff --git a/src/modules/gtk2/filter_dynamictext.c >> b/src/modules/gtk2/filter_dynamictext.c >> index 4b4c15e..472d5c8 100644 >> --- a/src/modules/gtk2/filter_dynamictext.c >> +++ b/src/modules/gtk2/filter_dynamictext.c >> @@ -230,9 +230,6 @@ static void apply_filter( mlt_filter filter, >> mlt_frame frame ) >> mlt_properties_set( watermark_properties, "producer.olcolour", >> mlt_properties_get( my_properties, "olcolour" ) ); >> mlt_properties_set( watermark_properties, "producer.pad", >> mlt_properties_get( my_properties, "pad" ) ); >> mlt_properties_set( watermark_properties, "producer.outline", >> mlt_properties_get( my_properties, "outline" ) ); >> - >> - // Process the filter >> - mlt_filter_process( watermark, frame ); >> } >> >> /** Get the image. >> @@ -264,6 +261,10 @@ static mlt_frame filter_process( mlt_filter >> filter, mlt_frame frame ) >> // Register the get image method >> mlt_frame_push_get_image( frame, filter_get_image ); >> >> + mlt_filter watermark = mlt_properties_get_data( >> MLT_FILTER_PROPERTIES(filter), "_watermark", NULL ); >> + if ( watermark ) >> + mlt_filter_process( watermark, frame ); >> + >> // Return the frame >> return frame; >> } > > That did the trick. Thanks for that. That bug was carried over from the > data_show filter. I'm not sure if I am motived to go back and fix it in > data_show. Someone might be counting on the current behavior. >
Thanks for letting me know. This is actually a weird side-effect from the addition of mlt_filter_get_position() in 2011, watermark's refactoring to use it, and then usage of watermark within another filter. So, data_show should get this change as well. It is definitely a regression bug. -- +-DRD-+ ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
