On Sun, Jan 12, 2014 at 4:41 PM, Brian Matherly <[email protected]> wrote: > No. Do not change it. I am aware and am in the process of fixing it. I'll > submit a patch for shotcut to integrate it after everything is working. I'll > let you know when I consider it done. > > I only pused it because i wanted to test the build process and becase it > does work using the two pass melt method with intermediate MLT file. > > Also, I have a proposal for two pass filters. I would like to make a rule > for all two pass filters that the analysis results must be stored in a > property named "result" and the results property must only be written after > the analysis pass has completed sucessfully. If we do this, then all two > pass filters (audio normalization, etc) can use the same application code in > shotcut. The application code will not have to know what filter it is > operating on. It just has to make sure it runs the job and then applies the > "results" property to the filter. I would also use this method with the > libebur128 based audio normalization filter I want to make.
OK, sounds good. I found that the garbled image was due to using mlt_image_yuv420p. On a profile that matches the clip, it works fine; problem otherwise. This is the first filter or transition to do processing in yuv420p revealing the problem. > ________________________________ > From: Dan Dennedy <[email protected]> > To: GitHub <[email protected]> > Cc: mlt-devel <[email protected]> > Sent: Sunday, January 12, 2014 6:13 PM > Subject: Re: [Mlt-devel] [mltframework/mlt] c2f4ab: Created a new module to > support vid.stab library. > > Ugh, the way you guys did this, it cannot be used in Shotcut without > some changes. As soon as you attach the filter, a vectors property > becomes available with one frame in it, and it switches to > get_image_and_transform. Then, it creates a garbled display. > Submitting it for analysis fails because the vectors property exists. > Really, the vectors property must only be written on the last frame. > Should I change this behavior? > > On Sat, Jan 11, 2014 at 6:39 PM, GitHub <[email protected]> wrote: >> Branch: refs/heads/master >> Home: https://github.com/mltframework/mlt >> Commit: c2f4ab489c5a3184e27511dd232602fefccb2790 >> >> https://github.com/mltframework/mlt/commit/c2f4ab489c5a3184e27511dd232602fefccb2790 >> Author: Jakub Ksiezniak <[email protected]> >> Date: 2014-01-06 (Mon, 06 Jan 2014) >> >> Changed paths: >> A src/modules/vid.stab/Makefile >> A src/modules/vid.stab/common.h >> A src/modules/vid.stab/configure >> A src/modules/vid.stab/factory.c >> A src/modules/vid.stab/filter_deshake.cpp >> A src/modules/vid.stab/filter_deshake.yml >> A src/modules/vid.stab/filter_detect.cpp >> A src/modules/vid.stab/filter_detect.yml >> A src/modules/vid.stab/filter_transform.cpp >> A src/modules/vid.stab/filter_transform.yml >> >> Log Message: >> ----------- >> Created a new module to support vid.stab library. >> >> >> Commit: bedb3bc88adb6733b0dc3b2264dccdbe45dc909b >> >> https://github.com/mltframework/mlt/commit/bedb3bc88adb6733b0dc3b2264dccdbe45dc909b >> Author: Jakub Ksiezniak <[email protected]> >> Date: 2014-01-07 (Tue, 07 Jan 2014) >> >> Changed paths: >> M src/modules/vid.stab/filter_deshake.cpp >> M src/modules/vid.stab/filter_deshake.yml >> M src/modules/vid.stab/filter_detect.cpp >> M src/modules/vid.stab/filter_detect.yml >> M src/modules/vid.stab/filter_transform.cpp >> M src/modules/vid.stab/filter_transform.yml >> >> Log Message: >> ----------- >> Update module to work with the latest vid.stab version 0.98. >> >> * Added a new property "zoomspeed" for adaptive zooming feature. >> * Removed a no longer used "sharpen" property. >> >> >> Commit: 473ece6065411284b74163d92d2cd12608875a1f >> >> https://github.com/mltframework/mlt/commit/473ece6065411284b74163d92d2cd12608875a1f >> Author: Brian Matherly <[email protected]> >> Date: 2014-01-07 (Tue, 07 Jan 2014) >> >> Changed paths: >> A gpl b/src/modules/vid.stab/gpl >> >> Log Message: >> ----------- >> Mark vid.stab module as GPL >> >> >> Commit: 280eedef0228a13381797dec1b6f08004cc89265 >> >> https://github.com/mltframework/mlt/commit/280eedef0228a13381797dec1b6f08004cc89265 >> Author: Jakub Ksiezniak <[email protected]> >> Date: 2014-01-09 (Thu, 09 Jan 2014) >> >> Changed paths: >> M src/modules/vid.stab/Makefile >> M src/modules/vid.stab/common.h >> M src/modules/vid.stab/configure >> M src/modules/vid.stab/factory.c >> M src/modules/vid.stab/filter_deshake.cpp >> M src/modules/vid.stab/filter_deshake.yml >> M src/modules/vid.stab/filter_detect.cpp >> M src/modules/vid.stab/filter_detect.yml >> M src/modules/vid.stab/filter_transform.cpp >> M src/modules/vid.stab/filter_transform.yml >> A src/modules/vid.stab/filter_vidstab.cpp >> A src/modules/vid.stab/filter_vidstab.yml >> >> Log Message: >> ----------- >> Added a fourth filter, that combines both detect and transform passes. >> >> * Increased a default smoothing factor, according to the original >> vid.stab default settings. >> * Added a deshake data clear when seeking is performed. >> * Added a version check in configure script. >> >> >> Commit: d316ee34eff2839ff93f7b1f2599203d3e90fffc >> >> https://github.com/mltframework/mlt/commit/d316ee34eff2839ff93f7b1f2599203d3e90fffc >> Author: Brian Matherly <[email protected]> >> Date: 2014-01-11 (Sat, 11 Jan 2014) >> >> Changed paths: >> M src/modules/vid.stab/Makefile >> M src/modules/vid.stab/common.h >> M src/modules/vid.stab/factory.c >> R src/modules/vid.stab/filter_detect.cpp >> R src/modules/vid.stab/filter_detect.yml >> R src/modules/vid.stab/filter_transform.cpp >> R src/modules/vid.stab/filter_transform.yml >> M src/modules/vid.stab/filter_vidstab.cpp >> M src/modules/vid.stab/filter_vidstab.yml >> >> Log Message: >> ----------- >> Merge filter_detect and filter_transform into filter_vidstab >> >> >> Compare: >> https://github.com/mltframework/mlt/compare/4b425d84e9af...d316ee34eff2 >> >> ------------------------------------------------------------------------------ >> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >> Learn Why More Businesses Are Choosing CenturyLink Cloud For >> Critical Workloads, Development Environments & Everything In Between. >> Get a Quote or Start a Free Trial Today. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >> _______________________________________________ >> Mlt-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/mlt-devel >> > > > > -- > +-DRD-+ > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > Mlt-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mlt-devel > > -- +-DRD-+ ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
