On Sun, Apr 13, 2014 at 2:19 AM, jbm <j...@kdenlive.org> wrote: > Hi Dan and everyone. > > I have been silent for almost a year due to some health issue, but I am fine > now and slowly starting to work again on Kdenlive. > > A recent Movit related commit creates a huge memory leak when seeking in > Kdenlive. The responsible commit is this one:
Do you have more information about what conditions are needed to reproduce this? Do I have to disable opengl? Do I have to apply cropping? I am not seeing the problem while scrubbing over a video clip for quite a while within Shotcut. I tested both with opengl module in use and not and with both cropping and not. Is it only when using a color or image producer? > https://github.com/mltframework/mlt/commit/3f84fe14c06956b5092c257fd27da490565566e5 > > Removing: > > *format = mlt_image_none; > > in filter_movit_crop.cpp seems to have some bad side effects. I was able to > fix > the leak by changing mlt_frame.c and adding some checks for mlt_image_glsl > like: > > (...) > > - if ( self->convert_image && requested_format != > mlt_image_none ) > + if ( self->convert_image && requested_format != > mlt_image_none && > requested_format != mlt_image_glsl ) { > self->convert_image( self, buffer, format, > requested_format ); > > (...) > > The full patch is attached. This change looks incompatible with filter movit.convert, which does need to be called when requested_format == glsl. > I also have a patch ready for the slowmotion producer (producer_framebuffer.c) > that makes it handle formats mlt_image_none and mlt_image_glsl so that when it > is asked for these formats, it queries the original avformat producer for its > format to set it. I will submit a pull request for it. > > Comments welcome, > > regards > jb > ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
