On Tue, Apr 15, 2014 at 2:39 AM, Janne Liljeblad <janne.liljeb...@gmail.com> wrote: > Hi, > > So I just send a pull request that add animated properties to 3 more > filters that use "start","end" thing for animating.
Thank you. > I grepped for property "end" and found the following services with > property "end": > > kdenlive/filter_wave.c > kdenlive/filter_boxblur.c > oldfilm/filter_vignette.c > core/transition_composite.c > normalize/filter_volume.c > core/filter_panner.c > core/transition_mix.c > core/filter_obscure.c > core/filter_brightness.c > motion_est/filter_autotrack_rectangle.c > > The following services have now been fixed: > > kdenlive/filter_wave.c > kdenlive/filter_boxblur.c > oldfilm/filter_vignette.c (in this "end" was commented out) > normalize/filter_volume.c > core/filter_panner.c > core/filter_brightness.c I have merged your pull request. > The following services had a geometry parameter with "start","end" and > it didn't look like they should be altered: > > core/transition_composite.c > core/filter_obscure.c > motion_est/filter_autotrack_rectangle.c mlt_geometry is deprecated by mlt_rect available through properties, but I understand your hesitation. transition_composite and filter_obscure use some custom geometry or extensions, and filter_autotrack_rectangle has some deep integration of mlt_geometry that needs very careful attention and regression testing. > core/transition_mix.c - I didn't want to touch this. This service I > use to mix all tracks audio together for output, and track mixing > shoud probably be done using "volume" filter attached to track. Mmm, mix combine=1 uses a special form of mixing that you probably want to keep and then use volume to provide gain envelopes. > All and all I think this round of fixing "start","end" services is > done after the current pull request is accepted, and we can do more > later if it seems we should. All numeric parameters that are mutable (the service understands changes to their values after the first call to get_image) should be enhanced to support animation. Even mutable string properties could support discrete animation for timed text scenarios. I suggest that we convert the remainder of the parameters (except start/end, of course) of the filters that have been recently updated to support animation. One will not need to create new properties to supersede the existing ones like you had to do for start/end. Rather, existing properties can be updated and will remain backwards compatible with non-keyframed values. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
