On Thu, Jun 26, 2014 at 10:17 AM, Maksym Veremeyenko <ve...@m1stereo.tv> wrote: > 26.06.14 20:07, Dan Dennedy написав(ла): > [...] >> OK, still some minor problems. In transition_matte_init(), you make >> property "factory" but that is never used. Remove it. >> > i will > >> The bigger problems are now in the yml file. Why did you not properly >> document the full_luma property using the yaml schema? All you have to >> do is look at some other yml files to see how it is done. Then, >> consult framework/metaschema.yaml for reference if needed. > full_luma is a property of frame from track B, but not transition.
Wow, I embarrassed I overlooked that. :o) >> Also, there >> are simple grammatical errors. If you feel your English is not strong, >> just let me know. Then, there is "FILL and KEY (MATTE) files." I >> understand what you mean, but that really needs to be expressed in MLT >> terms; otherwise, people ask "how do I give this my fill and key >> files?" You can probably just leave that out. > if it is possible, i will appreciate for you assistance in a fixing > grammar... > >> >> I do not know how much I like having the ffmpeg examples in there. If >> MLT is so great, why are we telling people to run a different program >> instead of melt, especially one whose command line syntax changes? >> frei0r.alpha0ps can convert alpha channel to grayscale. The challenge >> is to understand its parameters due to frei0r's API leading authors >> into mapping enumerations into the [0, 1] range. :-\ >> >> melt sg_gm_2013_clip_title.avi -attach frei0r.alpha0ps 0=0.21 >> >> I think to make a full range: >> >> melt sg_gm_2013_clip_title.avi -attach frei0r.alpha0ps 0=0.21 >> -consumer avformat:test.mp4 mlt_image_format=rgb24a pix_fmt=yuvj422p >> crf=10 preset=placebo an=1 >> > i did not install *frei0r* and never used it, but ffmpeg in my case is a > default and seems widely used. > > so we can and more example for creating matte track. Good point. Let me accept your latest patch as-is. I will remove that one line for the unused property and revise your docs for grammar and to also include melt examples. -- +-DRD-+ ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
