Branch: refs/heads/master
Home: https://github.com/mltframework/mlt
Commit: 2e78c56e38d6dfdb54bd8be2be618ddde1385125
https://github.com/mltframework/mlt/commit/2e78c56e38d6dfdb54bd8be2be618ddde1385125
Author: Markus Elfring <elfr...@users.sourceforge.net>
Date: 2014-09-20 (Sat, 20 Sep 2014)
Changed paths:
A coccinelle/delete_if4.cocci
Log Message:
-----------
Bug #MLT-216: Addition of a semantic patch file for listing of unnecessary
checks before a few known functions
This semantic patch pattern tries to find source code places where a check
is performed for an expression that is passed to a function (like "free")
which checks this single parameter itself for usability.
Redundant value or pointer checks can be avoided here.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Commit: ab419adc3f852bf296fdae3bf9bd95351102a73b
https://github.com/mltframework/mlt/commit/ab419adc3f852bf296fdae3bf9bd95351102a73b
Author: Markus Elfring <elfr...@users.sourceforge.net>
Date: 2014-09-20 (Sat, 20 Sep 2014)
Changed paths:
M src/framework/mlt_animation.c
M src/framework/mlt_consumer.c
M src/framework/mlt_geometry.c
M src/framework/mlt_profile.c
M src/framework/mlt_properties.c
M src/framework/mlt_property.c
M src/melt/melt.c
M src/modules/avformat/producer_avformat.c
M src/modules/avformat/vdpau.c
M src/modules/core/consumer_multi.c
M src/modules/gtk2/producer_pixbuf.c
M src/modules/linsys/consumer_SDIstream.c
M src/modules/plus/transition_affine.c
M src/modules/plusgpl/cJSON.c
M src/modules/videostab/filter_videostab.c
M src/modules/videostab/filter_videostab2.c
M src/modules/videostab/stabilize.c
M src/modules/videostab/tlist.c
M src/modules/vorbis/producer_vorbis.c
M src/modules/xml/producer_xml.c
Log Message:
-----------
Bug #MLT-216: Deletion of unnecessary checks before specific function calls
A couple of functions perform input parameter validation before their
implementations will try further actions with side effects. Some calling
functions perform similar safety checks.
Functions which release a system resource are occasionally documented
in the way that they tolerate the passing of a null pointer for example.
There is not a need because of this fact that a function caller repeats
a corresponding check.
A previously added semantic patch approach suggested the changes that are
shown here.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Commit: 892d9b6e3938379ad6956759aeb4fcc8eb310299
https://github.com/mltframework/mlt/commit/892d9b6e3938379ad6956759aeb4fcc8eb310299
Author: Markus Elfring <elfr...@users.sourceforge.net>
Date: 2014-09-20 (Sat, 20 Sep 2014)
Changed paths:
M src/modules/kino/filehandler.cc
M src/modules/qt/qimage_wrapper.cpp
Log Message:
-----------
Bug #MLT-216: Removal of unnecessary checks before a few calls of the C++
delete operator
The C++ delete operator can also handle passed null pointers on its own
without unexpected side effects.
http://www.parashift.com/c++-faq/delete-handles-null.html
It is therefore not needed to keep additional safety checks directly before
such function calls.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Commit: 5752a16fad3806b38ac40f48271be966e56a250a
https://github.com/mltframework/mlt/commit/5752a16fad3806b38ac40f48271be966e56a250a
Author: Dan Dennedy <d...@dennedy.org>
Date: 2014-09-20 (Sat, 20 Sep 2014)
Changed paths:
A coccinelle/delete_if4.cocci
M src/framework/mlt_animation.c
M src/framework/mlt_consumer.c
M src/framework/mlt_geometry.c
M src/framework/mlt_profile.c
M src/framework/mlt_properties.c
M src/framework/mlt_property.c
M src/melt/melt.c
M src/modules/avformat/producer_avformat.c
M src/modules/avformat/vdpau.c
M src/modules/core/consumer_multi.c
M src/modules/gtk2/producer_pixbuf.c
M src/modules/kino/filehandler.cc
M src/modules/linsys/consumer_SDIstream.c
M src/modules/plus/transition_affine.c
M src/modules/plusgpl/cJSON.c
M src/modules/qt/qimage_wrapper.cpp
M src/modules/videostab/filter_videostab.c
M src/modules/videostab/filter_videostab2.c
M src/modules/videostab/stabilize.c
M src/modules/videostab/tlist.c
M src/modules/vorbis/producer_vorbis.c
M src/modules/xml/producer_xml.c
Log Message:
-----------
Merge pull request #51 from elfring/Remove_unnecessary_checks1
Remove unnecessary null pointer checks.
Compare: https://github.com/mltframework/mlt/compare/2a9b15a403a6...5752a16fad38------------------------------------------------------------------------------
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
