On Mon, Sep 22, 2014 at 1:38 AM, Maksym Veremeyenko <ve...@m1stereo.tv>
wrote:
> MLT will not use it, but avcodecs will (mpeg1video and mpeg2video).
>> Therefore, this flag with the exact name "drop_frame_timecode" should be
>> set on the av_dict. I do not recall if the DeckLink produces timecode
>> values with a ';', but I think it does. Even if not, if the application
>> or user sets a timecode on the producer with a ';' it means drop-frame,
>> and we should set this flag.
>>
> i implemented that by another patch, because i an not sure if i make it
> properly. please review
In review, drop_frame_timecode only makes sense when we are setting
gop_timecode on the mpeg1/2 codec (priv_data), but we are not. I think at
one time there was a single "timecode" option that applied both to muxers
and codecs, and then it made more sense to also set drop_frame_timecode. We
will wait to see if there is a use case to also set gop_timecode. Thanks, I
pushed the first patch.
--
+-DRD-+
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
