Thanks, Maksym. I applied the latest patches.
On Mon, Nov 24, 2014 at 8:11 AM, Maksym Veremeyenko <ve...@m1stereo.tv>
wrote:
> 04.11.14 20:00, Dan Dennedy написав(ла):
>
>> On Tue, Nov 4, 2014 at 12:19 AM, Maksym Veremeyenko <ve...@m1stereo.tv
>> <mailto:ve...@m1stereo.tv>> wrote:
>>
>> Hi,
>>
>> during mem leak search i found that dumping pool state is helpfull,
>> so i cutted pool stat code into separate function
>>
>> Subject: [PATCH] implement mlt_pool_stat
>>
>> diff --git a/src/framework/mlt.vers b/src/framework/mlt.vers
>> index 7c4a22c..bf273b1 100644
>> --- a/src/framework/mlt.vers
>> +++ b/src/framework/mlt.vers
>> @@ -219,6 +219,7 @@ MLT_0.8.8 {
>> mlt_pool_purge;
>> mlt_pool_realloc;
>> mlt_pool_release;
>> + mlt_pool_stat;
>> mlt_producer_attach;
>> mlt_producer_clear;
>> mlt_producer_close;
>>
>>
>> You are not allowed to modify the symbols of an old version. You must
>> make a new block for the next version (MLT_0.9.4) that extends the
>> current version (MLT_0.9.2). Odd-numbered interim version numbers are
>> not used here.
>>
>> +mlt_log( NULL, MLT_LOG_VERBOSE, "%s: count %d\n", __FUNCTION__, c);
>>
>>
>> Since you have to resubmit patch 0001, please use the preferred format
>> of logging calls: mlt_log_verbose(). Yes, I realize other parts of the
>> code are using mlt_log(), but I want new/changed code to use the
>> preferred, more succinct format.
>>
>> Subject: [PATCH 2/3] descrease allocated pool items counter after
>> purging it
>>
>>
>> Please correct the spelling error (decrease) and if you use a sentence,
>> which is preferred, then do capitalize the first word and end with a
>> period. I am willing to correct those if that is the only thing wrong in
>> the patch, as is the case here.
>>
>> Subject: [PATCH 3/3] calculate total bytes allocated and used by
>> mlt_pool
>>
>> +mlt_log( NULL, MLT_LOG_VERBOSE, "%s: allocated %"PRId64" bytes,
>> used %"PRId64" bytes \n",
>>
>>
>> Use sentence for commit message and use mlt_log_verbose().
>>
>
> i updated patches. please review
>
> --
> ________________________________________
> Maksym Veremeyenko
>
--
+-DRD-+
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
