On Thu, Jan 29, 2015 at 8:24 AM, Maksym Veremeyenko <ve...@m1stereo.tv>
wrote:
> Hi,
>
> attached patch implement caching converted image produced by pango
> producer.
>
>
1.) It does not use mlt_cache, which means that if someone uses many pango
producers (perhaps they wrote something to read a subtitle) it will
consumer a lot of memory.
2.)
+ // convert
+ mlt_frame_get_image( frame, &image, format, &this->cached.width,
&this->cached.height, 0 );
You cannot call mlt_frame_get_image() here to do a conversion like that
because it affects mlt_frame.stack_image. I recall we have done that in the
past, but it caused problems, I think with tractor and/or transitions
(21a3f68). It would take more analysis to determine if it only affects
filters and not producers, but I just prefer to be safe and use
frame->convert_image() instead of this function that potentially affects
the image stack.
3.) +// *format = mlt_image_rgb24a;
Remove commented-out code.
--
+-DRD-+
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
