On Saturday 06 June 2015 20.22:27 Dan Dennedy wrote: > Most animation things are done through the Properties API, and just as > there is no Mlt::Property in C++ maybe same thing goes for animation. > However, a quick analysis reveals a few things an app might want to do not > yet available through Properties. Maybe, it is better to expose these > through properties: > mlt_properties_anim_is_keyframe > mlt_properties_anim_keyframe_type > mlt_properties_anim_length > mlt_properties_anim_remove > mlt_properties_anim_next > mlt_properties_anim_previous > Properties::anim_is_keyframe > Properties::anim_keyframe_type > Properties::anim_length > Properties::anim_remove > Properties::anim_next > Properties::anim_previous > > All of the above can just use simple, scalar types for parameters instead > of making apps deal with new Animation and AnimationItem objects, managing > them, and properly interfacing them with properties. Next and previous > would take and return a position.
Thanks for the quick reply. The first proposal seems easier on the app side, but will add some slight overhead I think, because for each request / change to the animation we must search for the animated property through: mlt_properties_find( self, name ); So it seems to me that the Mlt::Animation* would be slightly better, but might require slightly more work on the MLT side... Anyways, any of these solutions would be perfect for what we want to achieve, so if you have a preference, I am fine with it. Once a solution is decided, do you need help to implement it ? regards jb > Alternatively, Mlt::Properties::get_animation returns a Mlt::Animation*, > for which there are only methods to fill the gaps in the properties API: > Animation::is_keyframe > Animation::keyframe_type > Animation::get_length > Animation::remove (calls interpolate internally) > Animation::next > Animation::previous > > What do you think? > > On Sat, Jun 6, 2015 at 9:06 AM jb <j...@kdenlive.org> wrote: > > Hi all, > > > > As you might know, we have a student working on integrating animation > > property > > in Kdenlive. > > > > The mlt_animation stuff in MLT is still partially implemented in effects > > and > > transitions. As a starting point, I think we will try to work on the > > volume > > effect that has support for a "level" animated property. > > > > However, there is currently no Mlt++ wrapper for the MLT animation stuff. > > So I > > guess we have to add an MltAnimation class, similar to MltGeometry to > > allow > > easy access to the keyframes, types and values in Kdenlive. > > > > Is this approach ok for you ? Can we start working on a new MltAnimation > > class > > that will be added to Mlt++ or do you have other ideas about how to > > implement > > this ? > > > > Thanks & regards > > jb > > > > > > -------------------------------------------------------------------------- > > ---- _______________________________________________ > > Mlt-devel mailing list > > Mlt-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mlt-devel ------------------------------------------------------------------------------ _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
