On Tue, Feb 9, 2016 at 2:04 PM Jean-Baptiste Mardelle <j...@kdenlive.org>
wrote:
> Hi Dan, all.
>
> Since we started working on animation properties in Kdenlive, it would be
> nice to see more effects / transitions using it.
>
Yes, of course.
>
> I have done some quick tests to make frei0r use the animation properties
> instead of the old mlt_geometry, and a simple patch is available here:
>
>
> https://github.com/j-b-m/mlt/commit/1a765dec9d08300972e763e15eee558aaf4851a5
>
> It only works when using numbers for parameter's definitions, a few more
> lines would be needed for full integration.
>
Cool, but I think we should try to tackle this by-service or by-module in
the case of something like this where it is a bridge module. I prefer not
to have patches that only do a subset of the mutable properties. However, I
understand that sometimes things can get complicated, and you just need to
explain that. With this change, I think we should also ensure the service
metadata YAML indicates any keyframeable property as mutable.
Oh, I just remembered something. I think there is a problem with animating
frei0r parameters when using multi-threaded rendering. We need to use
f0r_construct and f0r_destruct for each frame within get_image. These
frei0r contexts hold parameter values, and one thread can be changing them
for its frame while another thread is accessing them for rendering a
different position. Therefore, each thread should have its own fre0r
context. However, there is some overhead with this such that perhaps it
should not do that in a single-thread render mode? In that case, we need to
make a new consumer_real_time frame property and, in frei0r, if that is
abs() > 1 do this extra context management?
>
> I think animation is backwards compatible with mlt_geometry for doubles
> but not 100% sure...
>
Yes, that was a design goal - in conjunction with mlt_rect, but it is not
100%. I think only the distort parameter of mlt_geometry is not included.
If that was used, we need to add a separate distort property to the service.
> So before making further attempts, I wanted to know if you are ok with this
> move or if you have other plans regarding the switch to animation
> properties.
>
>
No, personally, my delay on this has been awaiting Shotcut to drive its
progress. And, you know how it takes a while to be able to get around to
some things.
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
