On Sunday, April 17, 2016 2:26:02 AM CEST, Dan Dennedy wrote:
> Do you know about the facedetect and facebl0r filters in > frei0r? motion_est supplies data to other filters. Why doesn't > this one do that? I do not really care, and I have not looked at > it yet - not very motivated lately - just throwing out obvious > thoughts. I thought you might want to apply tracking to a mask > or to animate another filter's position, etc. Go ahead and merge > it when you like so long as configure and licensing are OK. Hi, Thanks for the review. I know the facedetect and facebl0r filters, but they give really bad and random results, which made them unusable for me when I tried them. Maybe I didn't spend enough time to configure them... The motion_est filter does set some properties on the frame for other filters. But it doesn't seem very standard. Another possibility would be to copy the region_filter, but not sure I have time for this in the near future. I made the changes you suggested and uploaded a few video demos of the filter in action if you want to see what it can do: http://j-b-m.ch/videos/ I will play a little more with this filter in Kdenlive to make sure everything works and will then prepare a merge to MLT (I will let you know when I think it's ready). Thanks, jb > Quick review: > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/configure#L15 > Top level configure sets LIBSUF, no need to repeat it here. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/configure#L30 > We generally do not echo when successful. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/configure#L6 > What requires OpenCV >= 3.1.0? See how other modules provide help: > https://github.com/mltframework/mlt/blob/master/src/modules/avformat/configure#L5 > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/factory.c#L3 > Bad copyright and author in factory.c. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/factory.c#L7 > This says GPL2, but other code in the module is LGPL. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/factory.c#L37 > Should we preface all OpenCV service names with "opencv."? > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.cpp#L69 > Should we bother to include stdlib just to use std::max() when > MLT now ensures a MAX C macro is defined? I don't care too much > either way. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.yml#L8 > Which license is this really using? > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.yml#L15 > Does try to do something resembling tracking without doing 2 > passes? I get the impression that it does, but if not clarify. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.yml#L1 > Usage of the "rect" parameter types requires metadata schema 0.3. > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.yml#L13 > Description should be a sentence (period missing). > > https://github.com/j-b-m/mlt/blob/opencv/src/modules/opencv/filter_tracker.yml#L37 > Please be aware that '>' in YAML is for non-preformatted text > blocks. Basically, all your white space including new lines is > squashed into one space character. That makes this description > all run together in the HTML or when using melt -query. Add a > colon after "object." There are other descriptions in here with > this same problem as well. > > > > ------------------------------------------------------------------------------ > Find and fix application performance issues faster with Applications Manager > Applications Manager provides deep performance insights into > multiple tiers of > your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
