I think it would make sense to change the order: Qt5 first, then Qt4.
I do not think a "--force" option is necessary. User can manually specify Qt 
using qt_libdir.

~Brian

      From: Jean-Baptiste Mardelle <j...@kdenlive.org>
 To: mlt-devel@lists.sourceforge.net 
 Sent: Tuesday, July 19, 2016 3:58 PM
 Subject: [Mlt-devel] qt/configure
   
Hi,

I just noticed that the configure script in qt module first checks for Qt4, 
and if not found checks for Qt5 (if the user did not manually supply a 
$qt_libdir).

Today, it seems to me that it would make more sense to invert the logic and 
first check for Qt5, because I think most people who have Qt5 also have Qt4 
for legacy applications, but it doesn't mean they want to compile MLT for 
Qt4.

So by inverting the pkg-config checks, if Qt5 is detected, it will compile 
against Qt5 and if not it will check for Qt4.

I could add a "--force-qt4" option for users that have both versions and 
want to compile against Qt4.

would that be ok for you ? It would allow most users to compile for Qt5 
without having to manually pass --qt-libdir and --qt-includedir

On second thought, maybe this would break existing automated build systems, 
so I could simple add a "--force-qt5" flag to bypass Qt4 detection?

(As a side note, I am also working on a fix for the qtblend compile problem 
on Qt5 < 5.2.0

regards
jb




------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel


   
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel

Reply via email to