> The biggest problem to review and approve the code in the mlt fork above > is that this initial commit to kdenlivetitle_wrapper.cpp > https://github.com/rlalik/mlt_tw/commit/894a656bd4885a0a461276b006c3cc4fa8a8518f > > It mixes meaningful behavior changes with heavy code reformatting. You > need to try to clean that up. Your existing commit history on that > branch is not interesting. I suggest to squash all the changes together, > and then try to manually revert the formatting changes.
Indeed, there are many changes in formatting I forgot about. The original code had a mixture of tabs and spaces of different length... hard to read. I made a new branch: https://github.com/rlalik/mlt_tw/tree/tw_2 With only two commits in respect to master: the last one is the same like typewriter branch (I made one commit in typewriter to clean up a Makefile, please update your local rep) and one branch before which is exactly the same code like in mlt-git, but reformatted (only kdenlive_wrapper.cpp since I didn't touch any other source file, except configure and Makefile). So making: git diff 2392507520039416a275ce0b24fc4b9b5353ebc5 you should see only proposed changes. Rafal ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
