Hi Dan, Thanks for the feedback. Indeed, a compilation flag would be a better idea than adding #defines everywhere.
I totally agree with you on minimizing the changes of the source code itself. I try to stick to the build system, and the main exception is about adding files to src/win32 whenever the code uses posix related headers that msvc is missing. This has been by the way the what I spent most of the porting time on so far. Since it seems that I'm heading to a correct direction, I'll keep on working on this and let you know when I get first results. Regards, É Le 18/01/2018 à 02:31, Dan Dennedy a écrit : > Hi, > This work looks like a good, serious effort. Some people have suggested > to switch to CMake, but it would be much work. I am intrigued to see > this in your patch - at least the start of it. > > Instead of adding #define HAVE_STRUCT_TIMESPEC to many files, what about > adding -DHAVE_STRUCT_TIMESPEC to CFLAGS on Windows? That is what I do in > the Shotcut build script. > > There has been a previous attempt or enquiry of sorts for MSVC also via > KDE for Windows, but at the time I rejected it as I did not want to get > stuck trying to maintain it. I think at the time there was much heavier > source changes required for MSVC's lack of support for C99. Now, that > has changed. I more open to this as long as there is not heavy source > code changes. > > Sorry, but I do not have any recommendations or further suggestions. > > On Tue, Jan 16, 2018 at 5:04 PM Élie Michel <e...@exppad.com > <mailto:e...@exppad.com>> wrote: > > Hi, > > I am currently trying to add a Kdenlive[1] package to the Craft[2] > system for building KDE applications on Windows, and for this I would > need to build MLT using, among others, MSVC. > > I already started working on it; the current state of my patch is > attached to this message. But since this turns out to be quite a piece > of work, I'd like to know what you think about this, whether there have > been previous attempts, and which would be your general recommandations > for achieving this. > > Thanks! > > Best, > Élie > > [1]: https://kdenlive.org/ > [2]: https://community.kde.org/Craft > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > Mlt-devel mailing list > Mlt-devel@lists.sourceforge.net <mailto:Mlt-devel@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/mlt-devel > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Mlt-devel mailing list > Mlt-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mlt-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
